Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Broken link in About Us #1800 #1801

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

NaincyKumariKnoldus
Copy link
Contributor

@NaincyKumariKnoldus NaincyKumariKnoldus commented Mar 6, 2022

Hey @tlylt I have fixed the link in About Us. I have updated it to https://nus.edu.sg/cdtl.
Please Review my PR.
Thanks!

Reviewer(tlylt) edits:
Fixes #1800
Proposed commit message: (wrap lines at 72 characters)
Fix broken link in UG's About Us page

Copy link
Contributor

@jovyntls jovyntls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for contributing :)

@NaincyKumariKnoldus
Copy link
Contributor Author

LGTM! Thank you for contributing :)

Can you merge my PR as you have approved this.

@tlylt
Copy link
Contributor

tlylt commented Mar 6, 2022

LGTM! Thank you for contributing :)

Can you merge my PR as you have approved this.

Hi @NaincyKumariKnoldus, thank you for raising the PR!

Just a friendly reminder: would be great if the PR description follows the PR template as specified here so that all relevant information is included. You may refer to other ongoing PRs for an example. e.g #1797

Otherwise LGTM (will be merged once one of our senior devs has taken a final look, thank you for your patience!)

Copy link
Contributor

@ryoarmanda ryoarmanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ryoarmanda ryoarmanda added this to the 4.0 milestone Mar 8, 2022
@ryoarmanda ryoarmanda merged commit 9e950bc into MarkBind:master Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken link in About Us
4 participants