Fix modal positioning in panel headers #1910
Conversation
|
https://deploy-preview-1910--markbind-master.netlify.app/userguide/syntaxcheatsheet I assume the above is the deployment preview of commit @jovyntls made, That's some great work. But when I navigated to Page Navigation menus in syntax cheat sheet. I still get two modals that overlap with each other. |
1 similar comment
|
https://deploy-preview-1910--markbind-master.netlify.app/userguide/syntaxcheatsheet I assume the above is the deployment preview of commit @jovyntls made, That's some great work. But when I navigated to Page Navigation menus in syntax cheat sheet. I still get two modals that overlap with each other. |
|
Hi @karnatisrinivas, thanks for looking through! However, this PR is not meant to fix the two overlapping modals. It's only meant to fix modals being positioned wrongly when they are used in a panel header, because the root cause of the overlapping modals is different. |
|
Oh my bad , i wasn't aware of that, I thought it meant to fix the issue. LGTM |
What is the purpose of this pull request?
Fixes the positioning issues from #1909
Overview of changes:
Fixes the styles from panel headers which was disrupting modal positioning.
margin: 0tomargin-bottom: 0which seems to be the minimal change that retains panel header styling without affecting modal positioningAnything you'd like to highlight / discuss:
The CSS here was inherited from MarkBind/vue-strap, where it was first implemented for minimal panels
Testing instructions:
Modals in panel headers should now be positioned correctly.
Proposed commit message: (wrap lines at 72 characters)
Checklist: ☑️