Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve User Guide - Adding Pages #1923

Merged
merged 1 commit into from
May 6, 2022
Merged

Improve User Guide - Adding Pages #1923

merged 1 commit into from
May 6, 2022

Conversation

tlylt
Copy link
Contributor

@tlylt tlylt commented May 4, 2022 •
edited
Loading

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • Others, please explain:

Overview of changes:

  • Update the adding pages section with more details, in particular, how to add a static web page into MarkBind
    • e.g. a generated HTML report from a code coverage tool, or a dashboard from RepoSense
  • Make a slightly unrelated fix of the modal rendering for 'live-preview', which the inline attribute resulted in the content not being rendered properly

Anything you'd like to highlight / discuss:
nil

Testing instructions:
https://deploy-preview-1923--markbind-master.netlify.app/userguide/addingpages

Proposed commit message: (wrap lines at 72 characters)
Improve User Guide - Adding Pages

Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

@tlylt tlylt requested a review from ong6 May 4, 2022 13:25
jonahtanjz
jonahtanjz approved these changes May 6, 2022
View reviewed changes
Copy link
Contributor

@jonahtanjz jonahtanjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @tlylt

LGTM 👍

@jonahtanjz jonahtanjz added this to the 4.0 milestone May 6, 2022
ong6
ong6 approved these changes May 6, 2022
View reviewed changes
Copy link
Contributor

@ong6 ong6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ong6 ong6 merged commit aaa9988 into MarkBind:master May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonahtanjz jonahtanjz jonahtanjz approved these changes

@ong6 ong6 ong6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tlylt @ong6 @jonahtanjz