Use css variables for fixed header style updates #1928
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Small cleanup / prelude to the ux issue #1560 to make things easier
Overview of changes:
<style>
sheet modifications are replaced in favour of css variables for simplificationAnything you'd like to highlight / discuss:
na
Testing instructions:
nav-menu-open
(mobile site nav dropdown / overlay)sidenote: noticed while tackling this that the z-index handling for the mobile overlay is broken in the case of no
header[fixed]
, we can fix this sometime separately from this issueProposed commit message: (wrap lines at 72 characters)
Use css variables for fixed header style updates
Checklist: ☑️