Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use css variables for fixed header style updates #1928

Merged
merged 3 commits into from
May 12, 2022

Conversation

ang-zeyu
Copy link
Contributor

@ang-zeyu ang-zeyu commented May 12, 2022

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • Others, please explain:

Small cleanup / prelude to the ux issue #1560 to make things easier

Overview of changes:
<style>sheet modifications are replaced in favour of css variables for simplification

Anything you'd like to highlight / discuss:
na

Testing instructions:

  • Fixed headers work
  • Anchor paddings should also still work
  • As well as nav-menu-open (mobile site nav dropdown / overlay)

sidenote: noticed while tackling this that the z-index handling for the mobile overlay is broken in the case of no header[fixed], we can fix this sometime separately from this issue

Proposed commit message: (wrap lines at 72 characters)
Use css variables for fixed header style updates


Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

@ang-zeyu ang-zeyu requested a review from jonahtanjz May 12, 2022 09:24
Copy link
Contributor

@jonahtanjz jonahtanjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issue after testing :)

sidenote: noticed while tackling this that the z-index handling for the mobile overlay is broken in the case of no header[fixed], we can fix this sometime separately from this issue

👍

LGTM!

@jonahtanjz jonahtanjz added this to the 4.0 milestone May 12, 2022
@jonahtanjz jonahtanjz merged commit 5e24215 into MarkBind:master May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants