Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR template #1941

Merged
merged 2 commits into from
May 30, 2022
Merged

Update PR template #1941

merged 2 commits into from
May 30, 2022

Conversation

tlylt
Copy link
Contributor

@tlylt tlylt commented May 28, 2022

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • Others, please explain:
    • Developer experience

Overview of changes:
Based on my personal experience with the project, thought it would be nice to update the PR template to make it more useful (for me and anyone else)

  • Add two more types of purpose that I think it's quite common: "DevOps" and "Improve developer experience"
  • Add two "width reference" to help with writing commit message
  • Minor clean up + update link address

Anything you'd like to highlight / discuss:
Any suggestion/idea/feedback is welcomed

Testing instructions:
nil

Proposed commit message: (wrap lines at 72 characters)
Update PR template


Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

@tlylt tlylt requested a review from ong6 May 28, 2022 15:28
Copy link
Contributor

@jonahtanjz jonahtanjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tlylt

LGTM 👍

@jonahtanjz jonahtanjz added this to the 4.0 milestone May 29, 2022
@jonahtanjz jonahtanjz merged commit abe7114 into MarkBind:master May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants