Migrate Plugin and PluginManager to TypeScript #2133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jovyntls
force-pushed
the
ts-migrate-plugin
branch
5 times, most recently
from
4fccf71
to
7bf4758
Compare
jovyntls
commented
Feb 6, 2023
| @@ -55,8 +73,6 @@ class PluginManager { | |||
| * Load all plugins of the site | |||
| */ | |||
| _collectPlugins() { | |||
| module.paths.push(path.join(this.config.rootPath, 'node_modules')); | |||
There was a problem hiding this comment.
Removed this line because the module object is not compatible with ES6 imports. This is manually implemented below around line 146.
jovyntls
changed the title
raysonkoh
reviewed
Feb 7, 2023
jovyntls
force-pushed
the
ts-migrate-plugin
branch
from
1822dfa
to
1ce0924
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Part of #1913
Overview of changes:
Migrate Plugin and PluginManager to TypeScript
Also removes
plugins/types.tsand moves the types toPlugin.jsProposed commit message: (wrap lines at 72 characters)
(rebase commit)
Checklist: ☑️