Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Icon and Media Support to List - Resolves #906 and #2272 #2316
Add Icon and Media Support to List - Resolves #906 and #2272 #2316
Changes from 34 commits
e485b3d
3572978
3b6f63e
fb80534
f72b476
afba2c1
262dd6f
10b7a0e
ce43e24
cd0a69e
21dd1a4
3588747
81183d0
59caa54
ef18aa1
4fc6ff7
4d107b9
a14d35a
eca3576
2548b86
050ebf1
d960ab4
82da76c
03b2c35
1c7806e
c23485b
6bfa00f
59c1473
1b031ac
a61c5b3
4404c3f
f73713b
a4d5c16
56522f9
cf178b9
3d435fa
35be3c3
42052d5
73a4bfc
3483691
3b3ce04
61a83ad
319ccc0
7367609
4cf49f2
7eaff80
982aa43
58ac61a
d94f448
1138459
f703ecc
319f2a8
c5d98e3
eea1431
09ba42e
d61e300
924c90c
77d4431
25662e1
097a23e
481228b
a0031d8
44929ac
8d6b7a6
0db4166
eb5a351
541ef91
2d1f16d
04d538e
6b65bde
e60535b
e46f500
68632d8
2d30fc1
5713956
f534d69
0e0aa0d
3d0f2f1
113251f
309a556
4768989
a541746
c5c901a
d76db28
c22cda1
cf0f67e
96c3332
2ba867e
71b66d0
9f65971
dd979b5
137b52b
45e4236
fad29bb
b005fc3
46081cc
0273b03
607b70d
df32b5f
9e0e616
5f8d782
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we can provide a way to use text instead of an icon. e.g.,
That's like numbered lists already, except the auto-incrementing the number. Anyway, can leave as a future enhancement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is feasible. The syntax for such a list would be {text="Step 2", class="text-warning"}. Since we can't reuse the icon attribute, the text will collide with the emoji name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sound good. As mentioned, we can leave it as a future enhancement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm... we use a new term
icon list
here. I don't mind adopting that (or some other name e.g.,Fancy Lists
) as our own standard name for this kind of customized lists but that needs to be upfront e.g., in that case this whole thing can be put under a heading calledicon lists
, instead ofCustomizing the list appearance
. What do you think?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The more I think about it, the more I feel like this feature deserves its own name, such as
Fancy Lists
. Most other similar tools have something comparable, so we can name it as we wish.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The icon list is an extension to the current unordered lists. Adding a new section for the icon list might not be visually appealing in the page navigation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It need not appear as a separate item. We can just replace
Customizing the list appearance
withFancy Lists
(without making it a pageNav heading) and use that term from that point to refer to customized lists.More generally, either we choose a name for this feature and use it consistently throughout, or not use a name at all, referring to the feature as 'customizing' instead. Currently, we throw in the term
icon list
suddenly in the middle of the feature description.Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.