This repository has been archived by the owner on Jul 12, 2020. It is now read-only.
Cache panel contents after first load #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openorclose
force-pushed
the
cache-panels
branch
2 times, most recently
from
1854861
to
38ccc5f
Compare
|
Forced push. Now that v-show is always used to show/hide panels, the v-else template is not used anymore and can be deleted. |
openorclose
force-pushed
the
cache-panels
branch
2 times, most recently
from
57c2ea5
to
3a0a681
Compare
|
Force pushed small bug fix. isCached was wrongly set to true even when localExpanded was changed from false to false in created(). |
Panels that do not have the preload attribute have their contents destroyed and recreated on each reopen. This causes issues such as inner text inputs and inner panels not remembering their previous state, and panels with src attribute repeating the same ajax request. See MarkBind/markbind#868 MarkBind/markbind#483 Let's have an additional `isCached` property, which is set to true whenever the content is/will be loaded. Only when isCached is true will the content be rendered and. As a side effect, since once the panel is loaded v-show is always used, the v-else part of the template is not needed anymore, which also reduces code duplication.
Chng-Zhi-Xuan
approved these changes
May 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [x] Enhancement to an existing feature
preloadattribute by default markbind#872What is the rationale for this request?
Content in panels are rerendered on each open, causing the above mentioned issues.
What changes did you make? (Give an overview)
Cache the rendered content on first load, then reuse it thereafter.
Provide some example code that this change will affect:
Should now remember its nested state upon reopening of outermost panel.
Testing instructions:
Test that content is not recreated (e.g. input elements maintain their text) every time a panel is toggled open.