Skip to content
This repository has been archived by the owner on Jul 12, 2020. It is now read-only.

Add dismissible attribute to Box #110

Merged
merged 1 commit into from
Jun 3, 2019

Conversation

alyip98
Copy link

@alyip98 alyip98 commented May 31, 2019

What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [x] Enhancement to an existing feature

Related PR

What is the rationale for this request?
We can enhance the Box feature to allow the boxes to be closed.

What changes did you make? (Give an overview)
Added a dismissible attribute to <box> that adds a close button to the Box.

Provide some example code that this change will affect:

<box type="info" dismissible>
Info box
</box>

Is there anything you'd like reviewers to focus on?

Testing instructions:
The user guide section in the netlify preview contains an example that demonstrates the dismissible attribute.

Proposed commit message: (wrap lines at 72 characters)
Let's enhance the Box feature by adding support for a dismissible
attribute, which adds a close button to the box.

Copy link

@Chng-Zhi-Xuan Chng-Zhi-Xuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine.

However, your commit message did not wrap at 72 characters.

Let's add an attribute to the <box> feature that allows users to
dismiss the box by clicking on a 'x' button.
@Chng-Zhi-Xuan Chng-Zhi-Xuan added this to the v2.0.1-markbind.28 milestone Jun 3, 2019
@Chng-Zhi-Xuan Chng-Zhi-Xuan merged commit aea00dc into MarkBind:master Jun 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants