Skip to content
This repository has been archived by the owner on Jul 12, 2020. It is now read-only.

Change style of trigger component #25

Merged
merged 1 commit into from
May 18, 2018

Conversation

Chng-Zhi-Xuan
Copy link

@Chng-Zhi-Xuan Chng-Zhi-Xuan commented May 17, 2018

What is the purpose of this pull request? (put "X" next to an item, remove the rest)

• [X] Bug fix

Fixes MarkBind/markbind#111

What is the rationale for this request?

  • User encountered bug where highlighted text blocks underlines for trigger elements.

What changes did you make? (Give an overview)

  • Modified trigger.vue at trigger.style to use ['text-decoration'] instead of ['border'].

Provide some example of changes:

Before After
trigger-underline-before trigger-underline-after
Note:
Triggers have a different style when set to "click", which will use dashes. 
Otherwise it defaults to dotted. However, popovers and tool-tips can also 
set "tigger" option to "click" but their style remains as dotted.

Might want to ensure consistency between components in another issue / PR

Is there anything you'd like reviewers to focus on?

  • Code style

Testing instructions:

  1. Type highlighted text using either <mark>text</mark> or <md>==text==</md> below a trigger element as shown in the example above.

@Chng-Zhi-Xuan Chng-Zhi-Xuan requested a review from acjh May 17, 2018 04:24
@acjh acjh added this to the v1.1.37-markbind.7 milestone May 17, 2018
@acjh acjh merged commit f59e84e into MarkBind:master May 18, 2018
@Chng-Zhi-Xuan Chng-Zhi-Xuan deleted the 111-highlight-blocking branch May 27, 2019 02:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Underlines are covered by highlights
2 participants