-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump up browser docker base image #3625
Labels
Milestone
Comments
@allcontributors please add @vmmattila for bugs |
I've put up a pull request to add @vmmattila! 🎉 |
aaltat
added a commit
to aaltat/robotframework-playwright
that referenced
this issue
May 28, 2024
aaltat
added a commit
that referenced
this issue
May 28, 2024
Was not fixed, building docker image failed |
Fixed in #3628 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Current Browser docker base image is mcr.microsoft.com/playwright:v1.30.0-focal,
which has node version v16.19.0. Version should be bumbped to get Node 20 version to container.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
node version should be 20
Actual result
node version v16.19.0
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
Additional context
building container using version 18.5.1 as base image gives dependency warnings:
#22 2.623 2024-05-28 10:12:53,806 [INFO ] Installing node dependencies...
9369#22 2.950 2024-05-28 10:12:54,132 [INFO ] Installing rfbrowser node dependencies at /home/pwuser/.local/lib/python3.8/site-packages/Browser/wrapper
9370#22 3.231 2024-05-28 10:12:54,413 [INFO ] npm WARN config production Use
--omit=dev
instead.9371#22 3.626 2024-05-28 10:12:54,808 [INFO ] npm WARN EBADENGINE Unsupported engine {
9372#22 3.626 2024-05-28 10:12:54,808 [INFO ] npm WARN EBADENGINE package: 'cli-truncate@4.0.0',
9373#22 3.626 2024-05-28 10:12:54,809 [INFO ] npm WARN EBADENGINE required: { node: '>=18' },
9374#22 3.626 2024-05-28 10:12:54,809 [INFO ] npm WARN EBADENGINE current: { node: 'v16.19.0', npm: '8.19.3' }
9375#22 3.626 2024-05-28 10:12:54,809 [INFO ] npm WARN EBADENGINE }
....
The text was updated successfully, but these errors were encountered: