Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latest bugfix branch breaks tmc 2130 #11179

Closed
wbarber69 opened this issue Jul 2, 2018 · 24 comments
Closed

latest bugfix branch breaks tmc 2130 #11179

wbarber69 opened this issue Jul 2, 2018 · 24 comments

Comments

@wbarber69
Copy link

I recently downloaded the latest bugfix branch today. I changed all settings to mimic what i was already using.. I had tmc 2130 drivers working perfectly with sensorless homing and everything. Now when i try to compile i get this error:

SENSORLESS_HOMING requires X_MIN_ENDSTOP_INVERTING and ENDSTOPPULLUP_XMIN when homing to X_MIN

I understand why its saying this, but i never needed to invert my endstops before, nor did I ever change these settings in any previous version of bugfix. I changed the settings it says to until the error went away but now i cannot get my x or y axis to move at all. I really dont know where to start here, as i have made this configuration setting for setting exactly as my old firmware, and now nothing works.

@wbarber69
Copy link
Author

I added my two builds, one works the other does not. remove the .txt and unrar

error-6-1-18.rar.txt
working-4-21-18.rar.txt

@wbarber69
Copy link
Author

sorry i uploaded the wrong previous version. but i am still having these issues. apparently along the way marlin now requires endstop pullups to be enebled for this feature. but even after i get the errors to go away i still cannot get any motion out of the steppers. reverting to a previous version that still requires pullups works as it should, and the latest has no motion.

@wbarber69
Copy link
Author

4-21-18.rar.txt older bugfix with everything working as it should. latest bugfix has no motion. and no errors as i followed the rules in sanity check

@thinkyhead
Copy link
Member

  • Either enable ENDSTOPPULLUPS or the individual axis pullups, but not both.
  • Don't forget to use M502, M500 after flashing the firmware.
  • If you're not using the X Max endstop for something, disable USE_XMAX_PLUG.
  • If you're not using the Z Max endstop for something, disable USE_ZMAX_PLUG.
  • Be sure to use the latest bugfix-1.1.x or bugfix-2.0.x branch so we're all on the same page.

@wbarber69
Copy link
Author

wbarber69 commented Jul 3, 2018 via email

@marcio-ao
Copy link
Contributor

@wbarber69: Could it be related to this change. That change was done because the default configuration was dangerous to some boards.

@joseandres42
Copy link

Hi, I'm having the same issues. I didn't need to invert the endstops logic before. My previous build was the bugfix-2.0.x from March:
Marlin-bugfix-2.0.x-2018-03-14.tar.gz
This is my new build:
Marlin-bugfix-2.0.x-2018-07-13.tar.gz
Removing the SENSORLESS_HOMING section from SanityCheck.h will let it compile, but one axis gets stuck in TRIGGERED state. Also, I'm using a modified RAMPS 1.4 board so I edited the pins_RAMPS.h file. Thank you :)

@wbarber69
Copy link
Author

wbarber69 commented Jul 13, 2018 via email

@joseandres42
Copy link

joseandres42 commented Jul 14, 2018

That was the first thing I tried, but if I invert what I had I get the X axis stuck in triggered:
Send: M119
Recv: Reporting endstop status
Recv: x_min: TRIGGERED
Recv: y_min: open
Recv: z_min: open
I'm using sensorless homing in both X and Y axes.

@wbarber69
Copy link
Author

wbarber69 commented Jul 14, 2018 via email

@joseandres42
Copy link

Yes, I'm using sensorless homing on both axes. I also have the pull-ups enabled. I tried enabling them individually and globally and it doesn't make a difference.

@wbarber69
Copy link
Author

wbarber69 commented Jul 15, 2018 via email

@joseandres42
Copy link

joseandres42 commented Jul 15, 2018

Yes, except the current which is a little different. I also tried different values for the homing sensitivity. The M119 gcode reports the X endstop as TRIGGERED but the M122 says the TMCs didn't trigger:
Recv: been triggered false false false false

@wbarber69
Copy link
Author

wbarber69 commented Jul 15, 2018 via email

@thinkyhead
Copy link
Member

thinkyhead commented Jul 15, 2018

but the M122 says the TMCs didn't trigger

That M122 output refers to the Overtemp Pre-Warn:

OT prewarn has
been triggered  false false false false

The M119 command does report the current status of stallguard-based sensorless homing, but they will rarely show "triggered" because stallguard-based endstops don't stay triggered for very long — they're only triggered when a motor is actively hitting a barrier.

@wbarber69
Copy link
Author

wbarber69 commented Jul 16, 2018 via email

@joseandres42
Copy link

It's not an electrical issue because my March build works just fine, and I'm using the same configuration. Both builds are uploaded in a previous comment.

@seandop
Copy link

seandop commented Jul 24, 2018

I'm experiencing a similar issue, and I'm still actively trying to nail it down. My build from 6/28 on the bugfix 1.1.x branch homes fine using sensorless homing on both X and Y. Using files from 7/19, my X stepper tries to home on the first G28 issued but it does so in StealthChop, rather than SpreadCycle. Obviously, stallguard won't work in StealthChop, so I shut off the machine before it rams the carriage into the endstop. After restarting the printer, the gantry assembly will raise on a G28, but the X and Y motors do not respond and eventually the printer is halted. X and Y will not attempt to home again unless I reflash the firmware. Re-flashing my build from 6/28 and again everything works fine...

UPDATE: After exhaustive brute force trial-and-error, I've determined that my issue is related to this commit from 6/30.https://github.com/MarlinFirmware/Marlin/commit/718a22e8366aa66f95c7800dd56960cc31e05050

If I comment out those pin assignments (I do use the MKS GEN L board), then everything works fine again. Note that I am using the Stock Creality CR-10 display, if that makes a difference...

@joseandres42
Copy link

I'm still having this issue, but I'm using a modified RAMPS board. I'm stuck my March build, and would love to update it.

@GibsDev
Copy link

GibsDev commented Aug 28, 2018

I am having the same issue. Never needed to invert my endstops before, and had sensorless homing working fine.

Edit: I'm using the MKS Gen 1.4 board, and had it configured with the MKS_GEN_L board setting. I switched to MKS_GEN_13 (the correct board) and now everything seems to work with the inverted settings.

@wbarber69
Copy link
Author

I finally went ahead and recently tried to upgrade to the latest bugfix branch again, and low and behold i had the exact same issue. I finally figured it out though and its pretty stupid. Im using the mks gen-l board and when i define that board in my configuration it then uses the pins.h for that specific board. well after hours of trying to finally nail this problem down i had a eureka moment. in the past the gen-l pins.h would just forward to the generic ramps pins.h but somewhere along the line there was some changes made to the gen-l pins.h and there are actually two lines in there calling up the cs pins for the x and y. and since i use software spi for my trinamic drivers and those cs pins are declared in the standard pins.h thery are overridden by the gen-l pins.h.. after changing the necessary cs pin settings in the gen-l pins.h file im back up and running on the latest bugfix branch.

@RiRilot
Copy link

RiRilot commented Jun 23, 2019

I am having the exact same issue but I'm using an SKR V1.3. With sensorless homing enabled I have to invert the X and Y endstops and configure pullups for both X and Y. When asking X or Y to home the endstops trigger immediately no matter what the value of M914 sensitivity.
I'm using the latest build of Marlin 2.0. Board is correctly defined as BIGTREE_V1_3

@seandop
Copy link

seandop commented Jun 23, 2019 via email

@github-actions
Copy link

github-actions bot commented Jul 5, 2020

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants