Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

length of arc is calculated incorrectly in G2/G3 motion #18141

Closed
eyal0 opened this issue May 28, 2020 · 2 comments
Closed

length of arc is calculated incorrectly in G2/G3 motion #18141

eyal0 opened this issue May 28, 2020 · 2 comments

Comments

@eyal0
Copy link
Contributor

eyal0 commented May 28, 2020

The length of the ARC is assumed to be MM_PER_ARC_SEGMENT yet the calculation might actually use a larger value if that length doesn't evenly divide the total length of the ARC.

Read more here.
@eyal0 eyal0 mentioned this issue May 28, 2020
Closed
eyal0 added a commit to eyal0/Marlin that referenced this issue May 28, 2020
@eyal0
Improve accuracy of G2 and G3 motion
b8998a7 
This fixes MarlinFirmware#18141 .
This fixes MarlinFirmware#17348 .
@eyal0 eyal0 mentioned this issue May 28, 2020
Merged
@sjasonsmith
Copy link
Contributor

@eyal0, I am presuming this can be closed since your own PR claiming to fix it has been merged.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eyal0 @sjasonsmith