[BUG] In 2.1.2, Ender-2: 'LCD_PINS_RS' was not declared in this scope #25204

probonopd · 2023-01-07T13:47:12Z

Did you test the latest `bugfix-2.1.x` code?

Could not build bugfix-2.1.x due to another issue. But could build 2.1.1 without issues.

Bug Description

Cannot compile Marlin 2.1.2 for Ender-2: 'LCD_PINS_RS' was not declared in this scope.

Marlin 2.1.1 works.

Bug Timeline

2.1.2

Expected behavior

Compiles.

Actual behavior

Compilation fails.

Compiling .pio/build/melzi_optimized/src/src/lcd/dogm/status_screen_DOGM.cpp.o
In file included from Marlin/src/lcd/dogm/../../inc/../pins/pins.h:319:0,
                 from Marlin/src/lcd/dogm/../../inc/MarlinConfig.h:34,
                 from Marlin/src/lcd/dogm/HAL_LCD_class_defines.h:24,
                 from Marlin/src/lcd/dogm/marlinui_DOGM.h:31,
                 from Marlin/src/lcd/dogm/marlinui_DOGM.cpp:42:
Marlin/src/lcd/dogm/marlinui_DOGM.cpp: In static member function 'static void MarlinUI::init_lcd()':
Marlin/src/lcd/dogm/../../inc/../pins/sanguino/pins_MELZI_CREALITY.h:82:38: error: 'LCD_PINS_RS' was not declared in this scope
   #define DOGLCD_CS                  LCD_PINS_RS
                                      ^
Marlin/src/lcd/dogm/marlinui_DOGM.h:231:23: note: in expansion of macro 'DOGLCD_CS'
     #define U8G_PARAM DOGLCD_CS, DOGLCD_A0                      // HW-SPI
                       ^~~~~~~~~
Marlin/src/lcd/dogm/marlinui_DOGM.cpp:267:14: note: in expansion of macro 'U8G_PARAM'
     u8g.init(U8G_PARAM);
              ^~~~~~~~~
Marlin/src/lcd/dogm/../../inc/../pins/sanguino/pins_MELZI_CREALITY.h:82:38: note: suggested alternative: 'LCD_PINS_D4'
   #define DOGLCD_CS                  LCD_PINS_RS
                                      ^
Marlin/src/lcd/dogm/marlinui_DOGM.h:231:23: note: in expansion of macro 'DOGLCD_CS'
     #define U8G_PARAM DOGLCD_CS, DOGLCD_A0                      // HW-SPI
                       ^~~~~~~~~
Marlin/src/lcd/dogm/marlinui_DOGM.cpp:267:14: note: in expansion of macro 'U8G_PARAM'
     u8g.init(U8G_PARAM);
              ^~~~~~~~~
*** [.pio/build/melzi_optimized/src/src/lcd/dogm/marlinui_DOGM.cpp.o] Error 1
========================= [FAILED] Took 39.47 seconds =========================

Environment      Status    Duration
---------------  --------  ------------
melzi_optimized  FAILED    00:00:39.470
==================== 1 failed, 0 succeeded in 00:00:39.470 ====================
Error: Process completed with exit code 1.

Steps to Reproduce

No response

Version of Marlin Firmware

2.1.2

Printer model

Creality Ender-2

Electronics

Stock

Add-ons

None

Bed Leveling

None

Your Slicer

None

Host Software

None

Don't forget to include

A ZIP file containing your Configuration.h and Configuration_adv.h.

Additional information & file uploads

My configuration can be seen at https://github.com/probonopd/marlin-builds/blob/main/customization/configuration/Creality/Ender-2

The text was updated successfully, but these errors were encountered:

ellensp · 2023-01-07T14:43:23Z

real Steps to Reproduce:

Set #define MOTHERBOARD BOARD_MELZI_CREALITY
and #define ENDER2_STOCKDISPLAY

You dont need all this other stuff complicating the issue

Bob-the-Kuhn · 2023-01-07T14:46:45Z

What LCD are you using?

There was a change made so that those pins are defined only when the CR10_STOCKDISPLAY is enabled. This change was made in PR #25012.

If I set the LCD to ENDER2_STOCKDISPLAY then I get the errors you listed. ENDER2_STOCKDISPLAY is what is enabled in the Marlin example configuration for ENDER2.

As a short term work around you could make the following change to the pins_MELZI_CREALITY.h file:

delete line 48 #if ENABLED(CR10_STOCKDISPLAY)
add line 48 #if EITHER(CR10_STOCKDISPLAY, ENDER2_STOCKDISPLAY)

My configuration can be seen at https://github.com/probonopd/marlin-builds/blob/main/customization/configuration/Creality/Ender-2

I'm confused. That file has nothing to do with the standard Marlin. Where are you getting your source files and config files?

probonopd · 2023-01-07T14:47:12Z

What LCD are you using?

I am using the stock display that came with the Ender-2.

I'm confused. That file has nothing to do with the standard Marlin. Where are you getting your source files and config files?

I am using the official Ender-2 configuration from https://github.com/MarlinFirmware/Configurations/tree/release-2.1.2/config/examples/Creality/Ender-2 and then apply my own (delta) changes on top of it using the commands in the file I had posted.

ellensp · 2023-01-07T14:51:02Z

@Bob-the-Kuhn he scripted github to build it for him, using stock ender2 example conf, and then running his modify script to make configuration changes
The default ender 2 config also triggers it.

probonopd · 2023-01-07T15:01:39Z

After doing

# Workaround for https://github.com/MarlinFirmware/Marlin/issues/25204
sed -i -e 's|ENABLED(CR10_STOCKDISPLAY)|EITHER(CR10_STOCKDISPLAY, ENDER2_STOCKDISPLAY)|g' Marlin/src/pins/sanguino/pins_MELZI_CREALITY.h

now I get:

Compiling .pio/build/melzi_optimized/src/src/lcd/dogm/status_screen_DOGM.cpp.o
In file included from Marlin/src/lcd/dogm/marlinui_DOGM.cpp:42:0:
Marlin/src/lcd/dogm/marlinui_DOGM.cpp: In static member function 'static void MarlinUI::init_lcd()':
Marlin/src/lcd/dogm/marlinui_DOGM.h:231:34: error: 'DOGLCD_A0' was not declared in this scope
     #define U8G_PARAM DOGLCD_CS, DOGLCD_A0                      // HW-SPI
                                  ^
Marlin/src/lcd/dogm/marlinui_DOGM.cpp:267:14: note: in expansion of macro 'U8G_PARAM'
     u8g.init(U8G_PARAM);
              ^~~~~~~~~
Marlin/src/lcd/dogm/marlinui_DOGM.h:231:34: note: suggested alternative: 'DOGLCD_CS'
     #define U8G_PARAM DOGLCD_CS, DOGLCD_A0                      // HW-SPI
                                  ^
Marlin/src/lcd/dogm/marlinui_DOGM.cpp:267:14: note: in expansion of macro 'U8G_PARAM'
     u8g.init(U8G_PARAM);
              ^~~~~~~~~
*** [.pio/build/melzi_optimized/src/src/lcd/dogm/marlinui_DOGM.cpp.o] Error 1

Bob-the-Kuhn · 2023-01-07T15:38:06Z

I screwed up. Now that I saved the ENDER2_STOCKDISPLAY config I get the same errors.

Bob-the-Kuhn · 2023-01-07T16:06:25Z

I just got around to compiling 2.1.1 with the default ENDER2 configs. It compiled correctly.

There are two ways to get bugfix-2.1.x to compile:

Comment out line 52 in pins_MELZI_CREALITY.h // #define LCD_PINS_DEFINED
Restore the 2.1.1 version of line 142 in pins_SANGUINOLOLU_11.h:

2.1.1: #if HAS_WIRED_LCD
bugfix-2.1.x: #if HAS_WIRED_LCD && DISABLED(LCD_PINS_DEFINED)

Bob-the-Kuhn · 2023-01-07T17:47:59Z

I just compiled it with #define LCD_PINS_DEFINED commented out and set the LCD to CR10_STOCKDISPLAY. Now I get warnings that LCD_PINS_RS is being defined in two places.:

pins_MELZI_CREALITY.h line 50
pins_SANGUINOLOLU_11.h line167

Compiling with 2.1.1 and CR10_STOCKDISPLAY enabled. No warnings. Time to look further at the changes.

Bob-the-Kuhn · 2023-01-07T21:29:58Z

Looks like the final fix is to keep LCD_PINS_DEFINED but add a couple more defines. No more warnings or errors and M43 shows that the pin/function assignments are the same as with 2.1.1.

  #define DOGLCD_CS                           LCD_PINS_RS
  #define DOGLCD_A0                           LCD_PINS_D4

Please try this file and see if your system works.

pins_MELZI_CREALITY.zip

MarlinFirmware/Marlin#25204 (comment)

probonopd · 2023-01-11T18:42:38Z

Thank you very much @Bob-the-Kuhn. Compilation succeeded, will test the firmware on the machine asap.

ellensp · 2023-01-19T13:21:03Z

@probonopd how goes that testing?

probonopd · 2023-01-20T17:55:23Z

Thanks for the ping @ellensp, my test was successful 👍

I think this can be merged.

Bob-the-Kuhn · 2023-01-20T22:12:38Z

PR #25258 fixes this bug so this issue is being closed.

github-actions · 2023-03-22T01:27:49Z

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

probonopd mentioned this issue Jan 7, 2023

In Marlin 2.1.2, Ender-2 fails with error: 'LCD_PINS_RS' was not declared in this scope probonopd/marlin-builds#1

Open

probonopd added a commit to probonopd/marlin-builds that referenced this issue Jan 7, 2023

Workaround for MarlinFirmware/Marlin#25204

b1918cd

Bob-the-Kuhn added the Bug: Confirmed ! label Jan 7, 2023

thisiskeithb added the C: Boards/Pins label Jan 7, 2023

probonopd added a commit to probonopd/marlin-builds that referenced this issue Jan 11, 2023

Define DOGLCD_CS and DOGLCD_A0

03889a8

MarlinFirmware/Marlin#25204 (comment)

invisiblek added a commit to invisiblek/Marlin that referenced this issue Jan 15, 2023

hax for ender2 from MarlinFirmware#25204

a9271ec

invisiblek added a commit to invisiblek/Marlin that referenced this issue Jan 19, 2023

hax for ender2 from MarlinFirmware#25204

7923735

Bob-the-Kuhn mentioned this issue Jan 20, 2023

Add ENDER2_STOCKDISPLAY back as valid display for Melzi_CREALITY #25258

Merged

Bob-the-Kuhn closed this as completed Jan 20, 2023

ellensp mentioned this issue Mar 18, 2023

Add Ender 2 test and fix pins #25538

Merged

github-actions bot locked and limited conversation to collaborators Mar 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BUG] In 2.1.2, Ender-2: 'LCD_PINS_RS' was not declared in this scope #25204

[BUG] In 2.1.2, Ender-2: 'LCD_PINS_RS' was not declared in this scope #25204

probonopd commented Jan 7, 2023 •

edited

Loading

ellensp commented Jan 7, 2023

Bob-the-Kuhn commented Jan 7, 2023

probonopd commented Jan 7, 2023 •

edited

Loading

ellensp commented Jan 7, 2023 •

edited

Loading

probonopd commented Jan 7, 2023 •

edited

Loading

Bob-the-Kuhn commented Jan 7, 2023

Bob-the-Kuhn commented Jan 7, 2023

Bob-the-Kuhn commented Jan 7, 2023

Bob-the-Kuhn commented Jan 7, 2023

probonopd commented Jan 11, 2023

ellensp commented Jan 19, 2023

probonopd commented Jan 20, 2023

Bob-the-Kuhn commented Jan 20, 2023

github-actions bot commented Mar 22, 2023

[BUG] In 2.1.2, Ender-2: 'LCD_PINS_RS' was not declared in this scope #25204

[BUG] In 2.1.2, Ender-2: 'LCD_PINS_RS' was not declared in this scope #25204

Comments

probonopd commented Jan 7, 2023 • edited Loading

Did you test the latest bugfix-2.1.x code?

Bug Description

Bug Timeline

Expected behavior

Actual behavior

Steps to Reproduce

Version of Marlin Firmware

Printer model

Electronics

Add-ons

Bed Leveling

Your Slicer

Host Software

Don't forget to include

Additional information & file uploads

ellensp commented Jan 7, 2023

real Steps to Reproduce:

Bob-the-Kuhn commented Jan 7, 2023

probonopd commented Jan 7, 2023 • edited Loading

ellensp commented Jan 7, 2023 • edited Loading

probonopd commented Jan 7, 2023 • edited Loading

Bob-the-Kuhn commented Jan 7, 2023

Bob-the-Kuhn commented Jan 7, 2023

Bob-the-Kuhn commented Jan 7, 2023

Bob-the-Kuhn commented Jan 7, 2023

probonopd commented Jan 11, 2023

ellensp commented Jan 19, 2023

probonopd commented Jan 20, 2023

Bob-the-Kuhn commented Jan 20, 2023

github-actions bot commented Mar 22, 2023

probonopd commented Jan 7, 2023 •

edited

Loading

Did you test the latest `bugfix-2.1.x` code?

probonopd commented Jan 7, 2023 •

edited

Loading

ellensp commented Jan 7, 2023 •

edited

Loading

probonopd commented Jan 7, 2023 •

edited

Loading