Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32F1: Init EEPROM SPI pin modes #14810

Merged
merged 2 commits into from
Aug 3, 2019

Conversation

tpruvot
Copy link
Contributor

@tpruvot tpruvot commented Aug 2, 2019

Marlin/src/HAL/shared/SpiEeprom.cpp only use WRITE()
which doesn't set the gpio input/outputs on start.

Marlin/src/HAL/shared/SpiEeprom.cpp only use WRITE()
which doesn't set the gpio input/outputs on start.
@tpruvot
Copy link
Contributor Author

tpruvot commented Aug 2, 2019

rmm, look like these pins were renamed, i need to double check... SCK

unsure, but its missing spiInit() too for the eeprom

@thinkyhead
Copy link
Member

The only reference so far is in the Longer pins…

//#define EEPROM_SCK  BOARD_SPI1_SCK_PIN   // PA5 pin 30
//#define EEPROM_MISO BOARD_SPI1_MISO_PIN  // PA6 pin 31
//#define EEPROM_MOSI BOARD_SPI1_MOSI_PIN  // PA7 pin 32

@tpruvot
Copy link
Contributor Author

tpruvot commented Aug 2, 2019

its in maple... the BOARD_xxxx

STM32F1/cores/maple/boards.h:156:#define BOARD_HAVE_SPI(n) (defined(BOARD_SPI##n##_NSS_PIN)  &&          \
STM32F1/cores/maple/boards.h:157:                           defined(BOARD_SPI##n##_SCK_PIN)  &&          \
STM32F1/cores/maple/boards.h:158:                           defined(BOARD_SPI##n##_MISO_PIN) &&          \
STM32F1/cores/maple/boards.h:159:                           defined(BOARD_SPI##n##_MOSI_PIN))

@tpruvot
Copy link
Contributor Author

tpruvot commented Aug 2, 2019

@tpruvot
Copy link
Contributor Author

tpruvot commented Aug 3, 2019

So, to explain better the longer board case... there is only this "optional" huge and fast eeprom on SPI1... the sdcard is not using SPI but SDIO pins...

@thinkyhead thinkyhead merged commit 4bd1e55 into MarlinFirmware:bugfix-2.0.x Aug 3, 2019
@tpruvot tpruvot deleted the stm32f1_spi_eeprom branch August 4, 2019 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants