Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.0.x] Autobuild formatting update #14857

Merged
merged 2 commits into from
Aug 7, 2019
Merged

[2.0.x] Autobuild formatting update #14857

merged 2 commits into from
Aug 7, 2019

Conversation

Bob-the-Kuhn
Copy link
Contributor

@Bob-the-Kuhn Bob-the-Kuhn commented Aug 6, 2019 •
edited
Loading

The new version of PlatformIO made some changes that threw off the formatting of the Autobuild script's display window.

  • In the SUMMARY section at the end the names of the results changed from SKIP to IGNORED and ERROR to FAILED. The new names were added to the list of items needing special color handling.
  • "\r\r" is now showing up which results in unwanted blank lines. A test was added that kills blank lines.
  • Killing all blank lines resulted in one place that wasn't as readable as before. A '\n' was added to the display write for that place.

The same changes are being done for bugfix-1.1.x via PR #14859.

@Bob-the-Kuhn
update to latest bugfix
62ca80f 
1) updated to klatest bugfix.

2) carried the Autobuild changes forward
Bob-the-Kuhn added a commit that referenced this pull request Aug 6, 2019
@Bob-the-Kuhn
move PR #14857 Autobuild update into bugfix 1.1.x
73f4027 
see PR #14857 for details
Bob-the-Kuhn added a commit that referenced this pull request Aug 6, 2019
@Bob-the-Kuhn
Revert "move PR #14857 Autobuild update into bugfix 1.1.x"
fdd2316 
This reverts commit 73f4027.
Bob-the-Kuhn added a commit to Bob-the-Kuhn/Marlin-Bob-2 that referenced this pull request Aug 6, 2019
@Bob-the-Kuhn
Move PR MarlinFirmware#14857 into 1.1.x
8dbae55 
see PR # 14857 for details
@Bob-the-Kuhn Bob-the-Kuhn mentioned this pull request Aug 6, 2019
Merged
@thinkyhead thinkyhead merged commit 5873b0b into MarlinFirmware:bugfix-2.0.x Aug 7, 2019
thinkyhead pushed a commit that referenced this pull request Sep 2, 2019
@Bob-the-Kuhn @thinkyhead
move PR #14857 Autobuild update into bugfix 1.1.x
fb276f6 
see PR #14857 for details
thinkyhead pushed a commit that referenced this pull request Sep 2, 2019
@Bob-the-Kuhn @thinkyhead
Revert "move PR #14857 Autobuild update into bugfix 1.1.x"
1ab59d6 
This reverts commit 73f4027.
@Bob-the-Kuhn Bob-the-Kuhn deleted the Autobuild-formatting-update branch January 15, 2020 09:17
bakaufman pushed a commit to bakaufman/Marlin that referenced this pull request Oct 16, 2020
@Bob-the-Kuhn @bakaufman
Revert "move PR MarlinFirmware#14857 Autobuild update into bugfix 1.1.x"
8710092 
This reverts commit 73f4027.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bob-the-Kuhn @thinkyhead