Add support for MKS SGEN_L V2 motherboard

[makerbase-mks]

Requirements

• Add support for MKS SGEN_L V2 motherboard

Description

MKS has release SGEN_L V2 motherboard
V2.0 comparison V1.0

• The CPU is LPC1769 120mhz
• Support 2 way PWM FANs
• The motherboard has 4KB EEPROM（AT24C32）
• Reserve more IO for users

Related Issues

• MKS SGEN_L V2 hardware datasheet：https://github.com/makerbase-mks/MKS-SGEN_L-V2/tree/master/Hardware

[anlupat]

@makerbase-mks please add extra comments on the pins file. About which connector to use for the fan(s). It is unclear to use the HE1 for the hotend fan when only using a single extruder. (if you only want to run the fan when the hotend is hot)

Function wise it is working great on my board in an Ender 3 with all the fancy things enabled.

[makerbase-mks]

@anlupat
HE1 for hotend FAN when extruder = 1?

[anlupat]

@anlupat
HE1 for hotend FAN when extruder = 1?

I now have it setup like this, to me it is more clear which terminal or connector to use:

#if HOTENDS == 1
#ifndef FAN_PIN
#define FAN_PIN P1_04 // Fan1 Connector - Part Cooling Fan E0
#endif
#ifndef FAN1_PIN
#define FAN1_PIN P2_06 // HE1 Terminal - Hotend Fan (can be used with EXTRUDER_AUTO_FAN_TEMPERATURE (eq. #define E0_AUTO_FAN_PIN FAN1_PIN))
#endif
#else
#ifndef HEATER_1_PIN
#define HEATER_1_PIN P2_06 // HE1 Terminal - Extruder 1
#endif
#ifndef FAN_PIN
#define FAN_PIN P1_04 // Fan1 Connector - Part Cooling Fan E0
#endif
#ifndef FAN1_PIN
#define FAN1_PIN P2_04 // Fan2 Connector - Part Cooling Fan E1
#endif
#endif

[thisiskeithb]

please add extra comments on the pins file.

This isn't done for other pins files when outputs are remapped since it's clear the remapping is happening right in the pins file, so I'm not sure we should start with this one.

If you're unsure of a pin's function, I'd recommend checking the manufacturer's pins diagram. Makerbase (and other manufacturers) host them in their respective github repos.

[anlupat]

then i would suggest to not use the HE1 terminal at all for a fan. Since nowhere in the documentation it is mentioned to use as a fan output.

[rhapsodyv]

Users are beginning to receive their mks gen l 2 board, and started asking for marlin support.

Anything holding this PR that I can help?

[sjasonsmith]

Are the Z2 serial pins actually needed?

I assume that when E1 is used as a Z2, it will automatically use the E1 serial pins as well.

[ils15]

Hi
PR still holding?
why?

[Kokorone]

Is there a reason this PR isnt integrated yet that needs to be changed? I've been using these pins with no issue for a while now

[thisiskeithb]

Is there a reason this PR isnt integrated yet that needs to be changed? I've been using these pins with no issue for a while now

There are other issues & PRs maintainers need to attend to.

[makerbase-mks]

I think that support for MKS SGEN_L V2 motherboard can be added first, and new functions can be added and improved later. Now more and more users need it urgently to use the latest firmware.

[sjasonsmith]

@thinkyhead as long as this isn't breaking the build, I think you should go ahead and merge it.
Even if there are some issues, it will let people start using the board and finding them.

[Doyle4]

Downloaded Marlin 2.0.6.1, downloaded 2.0.X bugfix, changed the files with a guide someone passed:

Download and replace this files: - It's files from Makerbase PR in to Marlin.
https://raw.githubusercontent.com/mks-viva/Marlin/4bdaec14dbb68006ef9067307143d45ea0080996/Marlin/src/pins/pins.h
https://raw.githubusercontent.com/mks-viva/Marlin/4bdaec14dbb68006ef9067307143d45ea0080996/Marlin/src/core/boards.h
https://raw.githubusercontent.com/mks-viva/Marlin/4bdaec14dbb68006ef9067307143d45ea0080996/Marlin/src/pins/lpc1769/pins_MKS_SGEN_L_V2.h
Path for replace you can see in URLs:

Marlin/src/pins/pins.h
Marlin/src/core/boards.h
Marlin/src/pins/lpc1769/pins_MKS_SGEN_L_V2.h

Im still getting failed..

Have to ask, how come a company has released a board thats not compatible to program?

[Kokorone]

I have no problems building and using the sgen l v2 on several printers right now with the current bugfix

[Doyle4]

Are you using the Bugfix 2.0.X to compile or swapping files over too 2.0.6.1?
Also, on a forum, some people are saying bugfix 2.0.X is 2.0.6 and not 2.0.6.1, is this correct? if its 2.0.6.1 i'll compile with bugfix instead as 2.0.6.1 does not work, nor with changing files.

[Kokorone]

Bugfix 2.0.x is always much more recent than any of the numbered releases. That’s the point of it being bugfix

[Doyle4]

Thought so, thank you.

Just tried and successful, although I had to turn off Filament runout sensor as it failed and can't find location to allocate a pin for it.