Fix IDEX X2 Direction #26958
Merged
Fix IDEX X2 Direction #26958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RPGFabi
pushed a commit
to RPGFabi/Marlin
that referenced
this pull request
Jun 15, 2024
* Fix IDEX X2 Direction * Sanity Check IDEX X1_MAX_POS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With IDEX enabled and INVERT_X_DIR set to true, X2 moved the wrong direction. The direction write macro now relies on INVERT_X2_DIR to be set independently from X. This checks if the value is not set, and defines it to match X1 if not.
Also added a sanity check in order to prevent misconfiguration as noted in #26915 where X1 was configured to allow travel beyond the X2 park point.