Fix UTF-8 (Cyrillic) on DOGLCD #27100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkyhead
force-pushed
the
bf2_fix_utf_dogm_PR
branch
from
caeaa10
to
429af69
Compare
1 task
thinkyhead
force-pushed
the
bf2_fix_utf_dogm_PR
branch
4 times, most recently
from
3f18144
to
1d37a89
Compare
|
Just stating the obvious. In the current state this fixes the reboot on mega2560, but brings back the broken language (also broken on the sim) Eg the is the main menu with #define LCD_LANGUAGE ru
This is what it should look like |
The results of such tests are indeed obvious, so thank you for doing them. Now I have the joyous task of puzzling out the magic combo that makes it work on both…. |
thinkyhead
force-pushed
the
bf2_fix_utf_dogm_PR
branch
from
1d37a89
to
d0aa563
Compare
thinkyhead
force-pushed
the
bf2_fix_utf_dogm_PR
branch
from
d0aa563
to
58cdcd2
Compare
|
Spend some hours looking at other ways and means, only to realize the string buffer was too small. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to #27097
This function always prints PGM strings so it had been modified to copy character bytes from flash in a loop. Apparently there are flaws, things broke. This reverts to the previous state before the fix was attempted. Maybe there is a simpler solution. We'll know after we do more playing around.