Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ultimate followup to Stepper/Planner patch #3671

Conversation

thinkyhead
Copy link
Member

@thinkyhead thinkyhead commented May 4, 2016

Methodically go through symbols in the recent Stepper/Planner patch, because science!

  • Search all Stepper/Planner symbols and apply prefixes
  • Make Stepper::microstep_mode() a public method
    • (Oops! @esenapaj beat me to it again.)
  • Encapsulate some private methods in Stepper / Planner
  • Inline some setters

- Search all symbols and apply prefixes where needed
- Encapsulate some private methods
- Inline some setters
- Make `microstep_mode` a public method
@thinkyhead thinkyhead force-pushed the rc_ultimate_stepper_planner_patch branch from 90eb794 to 6398d49 Compare May 4, 2016 00:07
@thinkyhead thinkyhead merged commit 5ff1099 into MarlinFirmware:RCBugFix May 4, 2016
@thinkyhead thinkyhead deleted the rc_ultimate_stepper_planner_patch branch May 4, 2016 00:12
@thinkyhead thinkyhead mentioned this pull request Jul 8, 2016
@jbrazio jbrazio modified the milestone: 1.1.0 Jul 18, 2016
drewmoseley pushed a commit to drewmoseley/Marlin that referenced this pull request Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants