Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UTF-8 language translation supports #4704

Closed
wants to merge 73 commits into from
Closed

UTF-8 language translation supports #4704

wants to merge 73 commits into from

Conversation

yhfudev
Copy link
Contributor

@yhfudev yhfudev commented Aug 26, 2016

It supports UTF-8 language translation header files, and generate the font data automatically.
So the language maintainer can use Unicode to translate their languages and don't need care about
the font if the font contains all of the glyph of their languages.

The HD44780 is also works.

The document(howto) for the new language engine is in the file buildroot/share/fonts/uxggenpages.md.

See the discussions:
#4539 (comment)

@yhfudev
Copy link
Contributor Author

yhfudev commented Aug 26, 2016

It needs complete U8GLIB including c code (u8g.h)!

@@ -620,18 +609,22 @@ static void lcd_implementation_status_screen() {
uint8_t n = LCD_WIDTH - (START_COL) - 1;

if (longFilename[0]) {
filename = longFilename;
filename = longFilename
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I'll submit the fix.

@thinkyhead
Copy link
Member

Overall an extraordinary effort. Well done! I hope we can get consensus among the project members on this soon. Can you supply some documentation on this for the Marlin website also?

@thinkyhead thinkyhead added Needs: Work More work is needed C: Language labels Aug 26, 2016
@thinkyhead
Copy link
Member

Read the output of Travis CI to see where it is hitting errors in the code, and fix them.

@yhfudev
Copy link
Contributor Author

yhfudev commented Aug 28, 2016

(Never mind, I get it re-installed by down-grade and upgraded.)

@thinkyhead,
Do you know where's the U8glib installed, after we execute

arduino --install-library "U8glib"

I need to check the files in the lib files, but I can't find it in all of "libraries" folders, including $HOME/Arduino/libraries, /usr/share/Arduino/libraries etc.

And how to uninstall it. How to find the config file for the libraries?

Thanks!

@yhfudev
Copy link
Contributor Author

yhfudev commented Sep 25, 2016

Can you please make the decision if you want the UTF-8 features integrated to the firmware or not?

@AnHardt
Copy link
Member

AnHardt commented Sep 25, 2016

Compared to the normal ASCII symbols all the special symbols (German and Greece) are (still) one pixel too deep.

@thinkyhead
Copy link
Member

thinkyhead commented Sep 26, 2016

Can you please make the decision if you want the UTF-8 features integrated to the firmware or not?

@yhfudev Can you please make the decision whether you want to play nicely or not? I can post a link for you on how not to be a jerk to the maintainers, if you need it. Hint 1: don't make petulant demands and please learn to be patient. We all have busy lives here and are doing the best we can.

As for me, I've been quite busy with other projects and don't get much time to review. Sure, maybe I'd like to see this integrated. But I don't have a graphical display currently to test with, and until this gets testing from more users, of course it's not going to get integrated. Only 3 people besides yourself have participated at all in this discussion. That's simply not enough to make a determination whether or not it's ready. And there is still the problem of the special symbols needing to be fixed.

@yhfudev yhfudev mentioned this pull request Nov 17, 2016
27 tasks
@thinkyhead
Copy link
Member

thinkyhead commented Dec 6, 2016

@yhfudev I'm working on making a new branch with this feature updated for RCBugFix. I'm cherry-picking the changes by hand. I will let you know when it's ready. It will replace this PR.

@yhfudev
Copy link
Contributor Author

yhfudev commented Dec 6, 2016

@thinkyhead That's a good news!

The issues that might annoy other developers/users which I concerned are:

  1. One of U8G C header file should be exposed for including, we need to make sure it's notified in the document. And it would be best if @olikraus be kindly to include the header file in the Arduino path of the releasing package for us so the end users don't need to aware of the changes.
  2. The scripts to generate the font header files. I found the font header would not need to be changed after a slight change for most time. I can rewrite the script in python if it helps.

@thinkyhead
Copy link
Member

@yhfudev I have a branch ready for your review at:
https://github.com/thinkyhead/Marlin/tree/rc_utf8_diff

I'm sure it isn't perfect. We will need to go through it carefully and make sure it works. It's completely built on the latest codebase.

I assume that the language_data_*.h files are generated, yes?
If so, I will drop them from the branch. You will probably want to rebuild them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Language Needs: Work More work is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants