-
-
Notifications
You must be signed in to change notification settings - Fork 19.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UTF-8 language translation supports #4704
Conversation
… the language engine.
It needs complete U8GLIB including c code (u8g.h)! |
@@ -620,18 +609,22 @@ static void lcd_implementation_status_screen() { | |||
uint8_t n = LCD_WIDTH - (START_COL) - 1; | |||
|
|||
if (longFilename[0]) { | |||
filename = longFilename; | |||
filename = longFilename |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I'll submit the fix.
Overall an extraordinary effort. Well done! I hope we can get consensus among the project members on this soon. Can you supply some documentation on this for the Marlin website also? |
Read the output of Travis CI to see where it is hitting errors in the code, and fix them. |
(Never mind, I get it re-installed by down-grade and upgraded.) @thinkyhead, arduino --install-library "U8glib" I need to check the files in the lib files, but I can't find it in all of "libraries" folders, including $HOME/Arduino/libraries, /usr/share/Arduino/libraries etc. And how to uninstall it. How to find the config file for the libraries? Thanks! |
Fix BLTOUCH string and SERVO_DELAY
We should use `constexpr` wherever it makes sense, for its added benefits. See http://stackoverflow.com/questions/13346879/const-vs-constexpr-on-variables
Homing/probing feedrate, comments
Replace untilted_stepper_position with planner.unapply_leveling, use in set_current_from_steppers_for_axis
Add probe option to position_is_reachable
Patch G29 for linear leveling, reachable with probe
26c9bd1
to
747a225
Compare
Can you please make the decision if you want the UTF-8 features integrated to the firmware or not? |
Compared to the normal ASCII symbols all the special symbols (German and Greece) are (still) one pixel too deep. |
@yhfudev Can you please make the decision whether you want to play nicely or not? I can post a link for you on how not to be a jerk to the maintainers, if you need it. Hint 1: don't make petulant demands and please learn to be patient. We all have busy lives here and are doing the best we can. As for me, I've been quite busy with other projects and don't get much time to review. Sure, maybe I'd like to see this integrated. But I don't have a graphical display currently to test with, and until this gets testing from more users, of course it's not going to get integrated. Only 3 people besides yourself have participated at all in this discussion. That's simply not enough to make a determination whether or not it's ready. And there is still the problem of the special symbols needing to be fixed. |
b97e3d4
to
0d9efb2
Compare
@yhfudev I'm working on making a new branch with this feature updated for |
@thinkyhead That's a good news! The issues that might annoy other developers/users which I concerned are:
|
@yhfudev I have a branch ready for your review at: I'm sure it isn't perfect. We will need to go through it carefully and make sure it works. It's completely built on the latest codebase. I assume that the |
It supports UTF-8 language translation header files, and generate the font data automatically.
So the language maintainer can use Unicode to translate their languages and don't need care about
the font if the font contains all of the glyph of their languages.
The HD44780 is also works.
The document(howto) for the new language engine is in the file buildroot/share/fonts/uxggenpages.md.
See the discussions:
#4539 (comment)