Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option for graphical overlay for Z-offset (Resubmission of #7350 and #7586) #7593

Merged
merged 1 commit into from
Sep 2, 2017

Conversation

marcio-ao
Copy link
Contributor

Resubmision of #7350 and #7586.

I deleted the repo on GitHub and started fresh with a new fork. Hopefully things match up now. Third try is a charm?

@thinkyhead thinkyhead merged commit 386b74f into MarlinFirmware:bugfix-1.1.x Sep 2, 2017
@thinkyhead
Copy link
Member

Seems solid now, thank you!

@Tannoo
Copy link
Contributor

Tannoo commented Sep 30, 2017

How do I correct the graphics the correct way?

The graphics overlay is only displaying about every other line. When I move the bitmap data to ultralcd.h, then all is fine. When it's in the dogm_bitmaps.h file, it's all messed up.

@thinkyhead
Copy link
Member

thinkyhead commented Oct 4, 2017

There should be no difference. The #include keyword makes dogm_bitmaps.h and ultralcd.h form one big blob of text. Perhaps the way it's being drawn is inappropriate, and this only manifests under certain conditions. Compare to other code that draws to the screen.

@Roxy-3D
Copy link
Member

Roxy-3D commented Oct 5, 2017

.h files should not generate code. We need everything in compliance with that rule. The whole problem with the ultralcd code is the .h files generate code. That needs to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants