Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate airflow and spark integrations #1585

Merged
merged 4 commits into from
Aug 20, 2021
Merged

Deprecate airflow and spark integrations #1585

merged 4 commits into from
Aug 20, 2021

Conversation

wslulciuc
Copy link
Member

@wslulciuc wslulciuc commented Aug 20, 2021 •
edited
Loading

This PR deprecates the airflow and spark integrations. Closes OpenLineage/OpenLineage#73

@wslulciuc
Deprecate airflow and spark integrations
303c3ad 
Signed-off-by: wslulciuc <willy@datakin.com>
@wslulciuc
continued: Deprecate airflow and spark integrations
ca45d2b 
Signed-off-by: wslulciuc <willy@datakin.com>
@wslulciuc wslulciuc requested review from mobuchowski and collado-mike and removed request for mobuchowski August 20, 2021 00:25
@wslulciuc wslulciuc added the review Ready for review label Aug 20, 2021
@wslulciuc
continued: Deprecate airflow and spark integrations
243673b 
Signed-off-by: wslulciuc <willy@datakin.com>
@wslulciuc wslulciuc changed the title Deprecate integrations Deprecate airflow and spark integrations Aug 20, 2021
@wslulciuc wslulciuc mentioned this pull request Aug 20, 2021
Closed
8 tasks
@codecov
Copy link

codecov bot commented Aug 20, 2021 •
edited
Loading

Codecov Report

Merging #1585 (1b0e7ac) into main (833dff1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1585   +/-   ##
=========================================
  Coverage     78.63%   78.63%           
  Complexity      959      959           
=========================================
  Files           188      188           
  Lines          5191     5191           
  Branches        415      415           
=========================================
  Hits           4082     4082           
  Misses          670      670           
  Partials        439      439

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 833dff1...1b0e7ac. Read the comment docs.

julienledem
julienledem reviewed Aug 20, 2021
View reviewed changes
Copy link
Member

@julienledem julienledem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.
Just a few comments

integrations/airflow/README.md Outdated Show resolved Hide resolved
integrations/spark/README.md Outdated Show resolved Hide resolved
@wslulciuc
Link to openlineage install for integrations
1b0e7ac 
Signed-off-by: wslulciuc <willy@datakin.com>
@wslulciuc wslulciuc removed the review Ready for review label Aug 20, 2021
@wslulciuc wslulciuc merged commit 369080b into main Aug 20, 2021
@wslulciuc wslulciuc deleted the deprecate-integrations branch August 20, 2021 18:59
@wslulciuc wslulciuc mentioned this pull request Dec 20, 2021
Closed
@wslulciuc wslulciuc mentioned this pull request Jan 5, 2022
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienledem julienledem julienledem approved these changes

@collado-mike collado-mike Awaiting requested review from collado-mike

@mobuchowski mobuchowski Awaiting requested review from mobuchowski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move Marquez integrations to OpenLineage
2 participants
@wslulciuc @julienledem