Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop requirement to provide marquez.yml for seed cmd #2094

Merged
merged 2 commits into from
Aug 30, 2022

Conversation

wslulciuc
Copy link
Member

@wslulciuc wslulciuc commented Aug 30, 2022

Problem

The marquez.yml arg is not used in the seed cmd.

Solution

Use io.dropwizard.cli.Command instead of io.dropwizard.cli.ConfiguredCommand to no longer require passing marquez.yml as an arg to the seed cmd:

java -jar marquez-api.jar seed --help
usage: java -jar marquez-api.jar
       seed [--url URL] --metadata METADATA [-h]

seeds the HTTP API server with metadata

named arguments:
  --url URL              the HTTP API server url (default: http://localhost:8080)
  --metadata METADATA    the path to the metadata file (ex: path/to/metadata.json)
  -h, --help             show this help message and exit

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

Signed-off-by: wslulciuc <willy@datakin.com>
@wslulciuc wslulciuc added the review Ready for review label Aug 30, 2022
@boring-cyborg boring-cyborg bot added api API layer changes docker labels Aug 30, 2022
@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #2094 (2c5ae77) into main (53460fa) will increase coverage by 0.04%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #2094      +/-   ##
============================================
+ Coverage     75.03%   75.08%   +0.04%     
  Complexity     1017     1017              
============================================
  Files           202      202              
  Lines          4783     4780       -3     
  Branches        392      390       -2     
============================================
  Hits           3589     3589              
+ Misses          756      753       -3     
  Partials        438      438              
Impacted Files Coverage Δ
api/src/main/java/marquez/cli/SeedCommand.java 7.69% <0.00%> (+0.54%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wslulciuc wslulciuc enabled auto-merge (squash) August 30, 2022 03:57
@wslulciuc wslulciuc merged commit df8cc76 into main Aug 30, 2022
@wslulciuc wslulciuc deleted the feature/make-seed-cmd-non-config branch August 30, 2022 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api API layer changes docker review Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants