Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate RunLink and JobLink #2342

Merged
merged 1 commit into from
Jan 5, 2023
Merged

validate RunLink and JobLink #2342

merged 1 commit into from
Jan 5, 2023

Conversation

pawel-big-lebowski
Copy link
Collaborator

Signed-off-by: Pawel Leszczynski leszczynski.pawel@gmail.com

Problem

ParentRunFacet may contain empty run section which results in NullPointerException.

Closes: #2263

Solution

Fix validation of ParentRunFacet

Note: All database schema changes require discussion. Please link the issue for context.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com>
@boring-cyborg boring-cyborg bot added the api API layer changes label Jan 3, 2023
@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Merging #2342 (83f9bf5) into main (ae6250a) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2342   +/-   ##
=========================================
  Coverage     76.72%   76.72%           
  Complexity     1177     1177           
=========================================
  Files           222      222           
  Lines          5354     5354           
  Branches        429      429           
=========================================
  Hits           4108     4108           
  Misses          768      768           
  Partials        478      478           
Impacted Files Coverage Δ
...main/java/marquez/service/models/LineageEvent.java 86.30% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Given that the ParentRunFacet marks the run and job as required, it makes sense to enforce the contract.

@pawel-big-lebowski pawel-big-lebowski self-assigned this Jan 4, 2023
@wslulciuc wslulciuc merged commit 81af59b into main Jan 5, 2023
@wslulciuc wslulciuc deleted the fix/parent-run-null-pointer branch January 5, 2023 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api API layer changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Marquez null pointer exception
2 participants