Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor dataset tags revisions #2754

Merged
merged 5 commits into from
Feb 25, 2024
Merged

Minor dataset tags revisions #2754

merged 5 commits into from
Feb 25, 2024

Conversation

phixMe
Copy link
Member

@phixMe phixMe commented Feb 22, 2024

  • Flexing tags with the header
  • Pointer on the expandable row
  • Inlining tags with our delete/close buttons
  • Adding transition on row expansion

image

One-line summary: Minor cleanup of UI for dataset tags, moves some pieces around, adds some css elements.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@boring-cyborg boring-cyborg bot added the web label Feb 22, 2024
Copy link

netlify bot commented Feb 22, 2024

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
🔨 Latest commit fa50517
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/65d6e94896e3c9000842d1ac

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c756cb2) 84.45% compared to head (fa50517) 84.45%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2754   +/-   ##
=========================================
  Coverage     84.45%   84.45%           
  Complexity     1416     1416           
=========================================
  Files           251      251           
  Lines          6447     6447           
  Branches        291      291           
=========================================
  Hits           5445     5445           
  Misses          850      850           
  Partials        152      152           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@wslulciuc wslulciuc merged commit 585068c into main Feb 25, 2024
16 checks passed
@wslulciuc wslulciuc deleted the web/cleanup-dataset-tags branch February 25, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants