Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web: Refine panel feature set #2798

Merged
merged 12 commits into from
Apr 17, 2024
Merged

Web: Refine panel feature set #2798

merged 12 commits into from
Apr 17, 2024

Conversation

phixMe
Copy link
Member

@phixMe phixMe commented Apr 17, 2024

Problem

Adds a slew of small refinements to improve the Marquez experience including:

  • Removal of Column Lineage and I/O tabs to concentrate on core experience
  • Adding info panels for jobs and datasets
  • Small style changes for tags, dialog and displays
  • Reordering tabs toolbar to better accommodate layout
  • Column Lineage Link
  • Misc aesthetic adjustments
  • Fix flashing dataset loading state
  • Align job and dataset panel view to be more similar
  • Fix removal of tags in open dropdown

One-line summary: Refinements adapting to user feedback.

Screenshots

image image

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@boring-cyborg boring-cyborg bot added the web label Apr 17, 2024
Copy link

netlify bot commented Apr 17, 2024

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
🔨 Latest commit 7b406d6
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/6620095b4ae84a0008c95268

@phixMe phixMe requested a review from wslulciuc April 17, 2024 06:09
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.47%. Comparing base (ac23c1b) to head (7b406d6).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2798   +/-   ##
=========================================
  Coverage     84.47%   84.47%           
  Complexity     1429     1429           
=========================================
  Files           251      251           
  Lines          6460     6460           
  Branches        299      299           
=========================================
  Hits           5457     5457           
  Misses          850      850           
  Partials        153      153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@wslulciuc wslulciuc added this to the 0.47.0 milestone Apr 17, 2024
@davidsharp7
Copy link
Member

Really like these changes!

@wslulciuc wslulciuc merged commit d0a4207 into main Apr 17, 2024
16 checks passed
@wslulciuc wslulciuc deleted the fix/web-visual-bugs branch April 17, 2024 18:19
@davidsharp7 davidsharp7 mentioned this pull request Apr 17, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants