Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance and Acuraccy Improvements #35

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Performance and Acuraccy Improvements #35

merged 2 commits into from
Jul 2, 2024

Conversation

CodeGod911
Copy link
Contributor

capture lines below 6 points for fast short lines
render only while drawing

render only while drawing
4c02a04 
capture lines below 6 points for fast short lines
@CodeGod911
Copy link
Contributor Author

CodeGod911 commented Jul 2, 2024 •
edited
Loading

This is related to the point i mentioned because of the event, constant drawing and a bug i found
Edit: The bug prevented perfect dots and drawed only dots for too fast lines with less than 6 points

@MarvinKlein1508
Copy link
Owner

MarvinKlein1508 commented Jul 2, 2024 •
edited
Loading

This seems to fix the displaying of pre existing signatures, however once you draw anything the preexisting signature will be overwritten. Related to #30

@CodeGod911
Copy link
Contributor Author

CodeGod911 commented Jul 2, 2024 •
edited
Loading

ill look into it dont know exactly. did u put it as background image before?

@MarvinKlein1508
Copy link
Owner

Ok. I've remove the canvas clearing. Otherwise it will be impossible to change an existing signature. Also it would break the background-image feature. Performance wise I don't run into any issues but I've got a quite powerful PC. Works fine for me in Firefox, Edge & Safari on mobile.

@MarvinKlein1508 MarvinKlein1508 merged commit 98e9614 into MarvinKlein1508:master Jul 2, 2024
1 check failed
@CodeGod911
Copy link
Contributor Author

ill check if frame time changes after big drawings too be sure

@CodeGod911
Copy link
Contributor Author

CodeGod911 commented Jul 2, 2024 •
edited
Loading

Times seem to be very consistent between.
Edit: (0.13ms - 0.34 ms on my pc with redrawing every frame not only when drawing)

@MarvinKlein1508 MarvinKlein1508 deleted the smoothandboundless branch July 2, 2024 16:40
@MarvinKlein1508
Copy link
Owner

Should work fine now in v8.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarvinKlein1508 MarvinKlein1508 MarvinKlein1508 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CodeGod911 @MarvinKlein1508