Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support of HSPI on ESP32 #177

Closed
levkovigor opened this issue May 18, 2019 · 1 comment
Closed

Add support of HSPI on ESP32 #177

levkovigor opened this issue May 18, 2019 · 1 comment
Assignees
@Marzogh
Labels
enhancement An enhancement to the library's function is proposed feature request This is a feature request mid priority This is a mid-priority item and will be actioned in the near future
Milestone
v3.4.0

Comments

@levkovigor
Copy link

levkovigor commented May 18, 2019 •
edited
Loading

In defines.h, SPIFlash.h and SPIFlash.cpp should be added || defined(__XTENSA__) to the line if defined (ARDUINO_ARCH_SAMD) || defined(ARCH_STM32). So it becomes possible to use HSPI on ESP32 SPIFlash flash(15, new SPIClass(HSPI))
@levkovigor levkovigor added the feature request This is a feature request label May 18, 2019
@Marzogh Marzogh self-assigned this May 20, 2019
@Marzogh Marzogh added this to the v3.4.0 milestone May 20, 2019
@Marzogh Marzogh added mid priority This is a mid-priority item and will be actioned in the near future enhancement An enhancement to the library's function is proposed labels Jun 1, 2019
Marzogh added a commit that referenced this issue Jun 1, 2019
@Marzogh
Updated change log to reflect error from previous commit. The change r…
b4676cb 
…esolves #177 not #117
@Marzogh
Copy link
Owner

Marzogh commented Jun 1, 2019

Resolved as of commit b4676cb . Will be released as part of v3.4.0 code. For now, feel free to use the code from the 'stable' branch. 🙂

@Marzogh Marzogh closed this as completed Jun 1, 2019
@Marzogh Marzogh mentioned this issue Jun 1, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Marzogh Marzogh

Labels
enhancement An enhancement to the library's function is proposed feature request This is a feature request mid priority This is a mid-priority item and will be actioned in the near future
Projects
None yet
Milestone
v3.4.0
Development

No branches or pull requests
2 participants
@levkovigor @Marzogh