Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange items at namespace scope #173

Closed
oblitum opened this issue Dec 22, 2018 · 7 comments
Closed

Strange items at namespace scope #173

oblitum opened this issue Dec 22, 2018 · 7 comments

Comments

@oblitum
Copy link

oblitum commented Dec 22, 2018

The last release doesn't present this issue, but master does. Just after std:: I'm getting all items looking like constructors:

19 52 29_22-12-2018

After one more char, it's back to normal:

19 53 59_22-12-2018

@MaskRay
Copy link
Owner

MaskRay commented Dec 22, 2018

I cannot reproduce with releases.llvm.org clang 6.0.1 + latest coc.nvim

Actually I think this might be an issue some days ago (completion items were not sorted, thus non-deterministic), but master doesn't have that problem.

@oblitum
Copy link
Author

oblitum commented Dec 22, 2018

Well sad, I cannot reproduce with clang 7.0.1 + ccls 0.20181111.1 + latest ccls.nvim either, but with clang 7.0.1 + ccls master (pacman -S ccls-git) + latest ccls.nvim it's consistent, in my machine at least.

@oblitum
Copy link
Author

oblitum commented Dec 22, 2018

Notice, I didn't use the "std::" namespace completion suggestion, I typed each char, to see result after inserting final :.

@MaskRay
Copy link
Owner

MaskRay commented Dec 23, 2018

I also tried releases.llvm.org clang 7.0.0 + latest coc.nvim but cannot reproduce.

I type s t d : : on an empty line but cannot observe what you saw.

Can you dump the textDocument/completion results (especially the isIncomplete property)?

@oblitum
Copy link
Author

oblitum commented Dec 23, 2018

@MaskRay before I send you that, please try this first. I noticed the issue doesn't happen without my .ccls, with it, it happens:

%clang
-Wall
-Wextra
%c -std=gnu11
%cpp -pedantic
%cpp -std=c++17

If I remove the %cpp -std=c++17 flag I get more usual results, with it I get those strange ones.

@MaskRay
Copy link
Owner

MaskRay commented Dec 23, 2018

If I remove the %cpp -std=c++17 flag I get more usual results, with it I get those strange ones.

Thanks! This is important. I think these (...) completion items are deduction guides that are represented as FunctionTemplate internally. I'll look into it.

The 0.20181111.1 release does not report these because the items: CompletionItem are truncated and they happen to not be included. The 2018-11-23 commit 544610c made the result deterministic but also exposed the issue.

@oblitum
Copy link
Author

oblitum commented Dec 23, 2018

Nice fixed.

MaskRay added a commit that referenced this issue Dec 24, 2018
MaskRay added a commit that referenced this issue Dec 25, 2018
MaskRay added a commit that referenced this issue Dec 25, 2018
MaskRay added a commit that referenced this issue Dec 25, 2018
MaskRay added a commit that referenced this issue Dec 26, 2018
MaskRay added a commit that referenced this issue Dec 28, 2018
MaskRay added a commit that referenced this issue Dec 28, 2018
MaskRay added a commit that referenced this issue Dec 28, 2018
MaskRay added a commit that referenced this issue Jan 2, 2019
MaskRay added a commit that referenced this issue Jan 2, 2019
MaskRay added a commit that referenced this issue Jan 9, 2019
MaskRay added a commit that referenced this issue Jan 11, 2019
MaskRay added a commit that referenced this issue Jan 11, 2019
MaskRay added a commit that referenced this issue Jan 13, 2019
MaskRay added a commit that referenced this issue Mar 18, 2019
MaskRay added a commit that referenced this issue Oct 24, 2019
MaskRay added a commit that referenced this issue Oct 24, 2019
MaskRay added a commit that referenced this issue Oct 24, 2019
MaskRay added a commit that referenced this issue Oct 24, 2019
MaskRay added a commit that referenced this issue Oct 24, 2019
MaskRay added a commit that referenced this issue Oct 24, 2019
MaskRay added a commit that referenced this issue Oct 24, 2019
MaskRay added a commit that referenced this issue Oct 24, 2019
MaskRay added a commit that referenced this issue Oct 24, 2019
MaskRay added a commit that referenced this issue Oct 24, 2019
MaskRay added a commit that referenced this issue Oct 24, 2019
MaskRay added a commit that referenced this issue Oct 25, 2019
MaskRay added a commit that referenced this issue Oct 25, 2019
MaskRay added a commit that referenced this issue Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants