v1.1 semantic highlight feature, introduced in specification 3.16.0 #788

FelipeLema · 2021-04-17T06:33:15Z

Continuation of #740 (fixed TODOs, sprinkled some using and lexicographical comparisons)

I originally sent this as a PR to @jlahoda, but they seem to have lost interest? anyway, I'm willing to take care of this until merged to main branch

textDocument/semanticTokens/range
textDocument/semanticTokens/full
~~textDocument/semanticTokens/full/delta~~

…n specification 3.16.0.

- add overhead code for new method - move code from "semantic tokens for full document" to "semantic tokens for range in document" - add range delimitation to function - make "full document" use "range that covers all document"

FelipeLema · 2021-05-17T16:13:16Z

this is ready to be merged (deltas are not mandatory). I've tested this using Emacs+lsp-mode and it seems to work Ok.

I will come back to work in deltas in a few weeks

- Move SemanticTokens to QueryFile - Add SemanticTokensId (though still returning SemanticTokens) - Save latest SemanticTokensId in QueryFile (latest semantic token sent is associated to a file)

FelipeLema · 2021-06-01T14:02:07Z

I just cancelled deltas because I don't see much support for it in the wild, and it looks like quite the work to do.

This PR is ready to be... uhm... pulled.

src/position.hh

src/query.hh

src/messages/textDocument_semanticToken.cc

FelipeLema · 2021-06-21T17:07:12Z

re deltas: prabirshrestha/vim-lsp#633 (comment)

lsp-mode was complaining that generated json was not properly parsed

MaskRay · 2021-06-23T03:02:34Z

The biggest problem for me is that I cannot test this.

Do you know how to test lsp-mode semantic tokens? I dropped the ccls-style semantic highlighting locally in emacs-ccls but cannot observe any fontlock color differences even if I have set (setq lsp-semantic-tokens-mode t).

-- i/ccls.el
+++ w/ccls.el
@@ -162,4 +162,3 @@ DIRECTION can be \"D\", \"L\", \"R\" or \"U\"."
   :notification-handlers
-  (lsp-ht ("$ccls/publishSkippedRanges" #'ccls--publish-skipped-ranges)
-          ("$ccls/publishSemanticHighlight" #'ccls--publish-semantic-highlight))
+  (lsp-ht ("$ccls/publishSkippedRanges" #'ccls--publish-skipped-ranges))
   :initialization-options (lambda () ccls-initialization-options)

Please don't use //!. Just keep the original comments.

The commits should better be squashed.

src/messages/textDocument_semanticToken.cc

MaskRay · 2021-06-23T03:05:35Z

src/messages/initialize.cc

+  "macro"
+};
+
+const char * SEMANTIC_MODIFIERS[] = {


clang-format should make it const char *SEMANTIC_MODIFIERS[] =

The preferred style is kSemanticModifiers

MaskRay · 2021-06-23T03:06:18Z

src/messages/textDocument_semanticToken.cc

+using namespace clang;
+
+namespace {
+


single blank line

MaskRay · 2021-06-23T05:51:47Z

remove $ccls/publishSemanticHighlight

This is not good. $ccls/publishSemanticHighlight provides rainbow colors which I don't think semantic tokens can do.

FelipeLema · 2021-06-23T18:19:26Z

Do you know how to test lsp-mode semantic tokens?
I'm using latest lsp-mode with lsp-semantic-tokens-mode set to t. Do mind that the text properties differ between lsp-semantic-tokens.el and ccls.el differ.

$ccls/publishSemanticHighlight provides rainbow colors which I don't think semantic tokens can do.

will replace with something like $ccls/publishRainbowHighlight

FelipeLema · 2021-06-25T16:48:29Z

I'm looking to decouple the rainbowing from the ccls Emacs package now.

See discussion after this comment

FelipeLema · 2021-07-13T21:51:01Z

can anyone walk me through the "rainbowing process"? any pics / video samples of what end users will see?

jlahoda and others added 9 commits December 25, 2020 11:22

First attempt to include the semantic highlight feature, introduced i…

503ac95

…n specification 3.16.0.

Removing unnecessary include.

013b655

name types for (trace|read)ability

a4de46b

use tuple for lexicographical comparison

ca51f9e

handle TODOs, imprve readbility

554833a

fix type

c986030

fix compilation

661870a

textDocument/semanticTokens/range

84a00f6

- add overhead code for new method - move code from "semantic tokens for full document" to "semantic tokens for range in document" - add range delimitation to function - make "full document" use "range that covers all document"

fix debug build

700c1ff

MaskRay force-pushed the master branch 9 times, most recently from 94ba2b3 to c018bce Compare May 9, 2021 18:34

FelipeLema mentioned this pull request May 10, 2021

Missing highlight on some keywords jackguo380/vim-lsp-cxx-highlight#3

Closed

use symbols that "intersect", rather than "begin" within range

16d7ef6

FelipeLema added 2 commits May 28, 2021 13:22

use SemanticTokensWithId internally

ab53802

- Move SemanticTokens to QueryFile - Add SemanticTokensId (though still returning SemanticTokens) - Save latest SemanticTokensId in QueryFile (latest semantic token sent is associated to a file)

indent fix

e702d33

MaskRay requested changes Jun 6, 2021

View reviewed changes

src/position.hh Outdated Show resolved Hide resolved

src/query.hh Outdated Show resolved Hide resolved

src/messages/textDocument_semanticToken.cc Show resolved Hide resolved

FelipeLema added 5 commits June 16, 2021 18:03

use different container per gh review

de89bae

comply with github review comments

1ff4931

omit copyright year per review

79c0bee

remove $ccls/publishSemanticHighlight

c9f36a3

remove absctractions per github review

5e2ea98

remove another unnecessary abstraction per gh review

000fd75

correct usage of "empty (list) of params"

03324a1

lsp-mode was complaining that generated json was not properly parsed

MaskRay reviewed Jun 23, 2021

View reviewed changes

FelipeLema added 3 commits June 23, 2021 12:29

remove using per github review

b07d39b

clang-format file

20ef17c

remove surrounding braces on single-if-statements

dc9ba78

FelipeLema mentioned this pull request Jun 24, 2021

[3.16] Support semanticTokens missing methods emacs-lsp/lsp-mode#2448

Closed

FelipeLema added 2 commits August 16, 2021 18:31

fix build (no more using ID)

b27b1a6

improve log messages: add info

7c1d53b

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v1.1 semantic highlight feature, introduced in specification 3.16.0 #788

v1.1 semantic highlight feature, introduced in specification 3.16.0 #788

FelipeLema commented Apr 17, 2021 •

edited

Loading

FelipeLema commented May 17, 2021

FelipeLema commented Jun 1, 2021

FelipeLema commented Jun 21, 2021

MaskRay commented Jun 23, 2021 •

edited

Loading

MaskRay Jun 23, 2021

MaskRay Jun 23, 2021

MaskRay commented Jun 23, 2021

FelipeLema commented Jun 23, 2021

FelipeLema commented Jun 25, 2021

FelipeLema commented Jul 13, 2021

v1.1 semantic highlight feature, introduced in specification 3.16.0 #788

v1.1 semantic highlight feature, introduced in specification 3.16.0 #788

Conversation

FelipeLema commented Apr 17, 2021 • edited Loading

FelipeLema commented May 17, 2021

FelipeLema commented Jun 1, 2021

FelipeLema commented Jun 21, 2021

MaskRay commented Jun 23, 2021 • edited Loading

MaskRay Jun 23, 2021

Choose a reason for hiding this comment

MaskRay Jun 23, 2021

Choose a reason for hiding this comment

MaskRay commented Jun 23, 2021

FelipeLema commented Jun 23, 2021

FelipeLema commented Jun 25, 2021

FelipeLema commented Jul 13, 2021

FelipeLema commented Apr 17, 2021 •

edited

Loading

MaskRay commented Jun 23, 2021 •

edited

Loading