Trigger the bound function to the gcode to run on update even if there is no gcode #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is no gcode This is needed to fix issue #775 which was causing a bug where the background image didn't behave correctly when there was no gcode file open because the file updateGcode function opts out if there is no file, but we need the refresh process to run
|
Congratulations on the pull request @BarbourSmith Now we need to decide as a community if we want to integrate these changes. Vote by giving this comment a thumbs up or a thumbs down. Votes are counted in 48 hours. Ties will not be merged. I'm just a robot, but I love to see people contributing so I'm going vote thumbs up! |
|
What do you think about merging this one before the robot times out, to get it into tomorrow’s release? |
|
I think that is a good idea 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to fix issue #775 which was causing a bug where the background image didn't behave correctly when there was no gcode file open because the file updateGcode function opts out if there is no file, but we need the refresh process to run