Add link to external visualisation tool #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prototype for Link out to external Visualisation via the https://metabolomics-usi.ucsd.edu/ Closes mwang87/MetabolomicsSpectrumResolver#62 Improvements could be a nicer element (Link out icon ?) Currently an example is e.g. https://msbi.ipb-halle.de/MassBank/RecordDisplay.jsp?id=UA002901 Yours, Steffen
|
how is this different to the splash, what is the need for this?
…On Tue, Jan 28, 2020 at 9:56 PM Steffen Neumann ***@***.***> wrote:
Prototype for Link out to external Visualisation via the
https://metabolomics-usi.ucsd.edu/
Closes mwang87/MetabolomicsSpectrumResolver#62
<mwang87/MetabolomicsSpectrumResolver#62>
Improvements could be a nicer element (Link out icon ?)
Currently an example is e.g.
https://msbi.ipb-halle.de/MassBank/RecordDisplay.jsp?id=UA002901
Yours, Steffen
------------------------------
You can view, comment on, or merge this pull request online at:
#218
Commit Summary
- Add link to external visualisation tool
File Changes
- *M* MassBank-Project/MassBank/src/main/webapp/RecordDisplay.jsp
<https://github.com/MassBank/MassBank-web/pull/218/files#diff-0> (5)
Patch Links:
- https://github.com/MassBank/MassBank-web/pull/218.patch
- https://github.com/MassBank/MassBank-web/pull/218.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#218?email_source=notifications&email_token=AAAD73DU6F2G5FL43NN6NPTRACSZPA5CNFSM4KM2I7HKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IJLN6PQ>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAD73AM4A4HMRZ4TYL2XU3RACSZPANCNFSM4KM2I7HA>
.
--
------------------------------------------------------------
Lead Software Developer - Fiehnlab, UC Davis
gert wohlgemuth
work:
http://fiehnlab.ucdavis.edu/staff/wohlgemuth
phone:
530 665 9477, *email preferred!*
linkedin:
https://www.linkedin.com/in/berlinguyinca
<http://www.linkedin.com/profile/view?id=28611299&trk=tab_pro>
|
|
Hi Gerd, the external visualisation is in my opinion independent of the SPLASH. The embedded MassBank viewer is JavaScript and can't be put into a manuscript (or supplemental information), |
The example we had included a typo: mwang87/MetabolomicsSpectrumResolver#67
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prototype for Link out to external Visualisation via the https://metabolomics-usi.ucsd.edu/
Closes mwang87/MetabolomicsSpectrumResolver#62
Improvements could be a nicer element (Link out icon ?)
Currently an example is e.g. https://msbi.ipb-halle.de/MassBank/RecordDisplay.jsp?id=UA002901
Yours, Steffen