Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some server helper's function test #193

Merged

Conversation

ta1m1kam
Copy link
Contributor

I add some server helper's function tests.

@MasterKale
Copy link
Owner

@TaigaMikami Thank you for submitting more tests! These all look good. I just had the one request for one more test and then I think these are ready to merge.

Copy link
Owner

@MasterKale MasterKale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :shipit:

@MasterKale MasterKale merged commit f46a315 into MasterKale:master Apr 12, 2022
@MasterKale MasterKale added the package:server @simplewebauthn/server label Apr 13, 2022
@ta1m1kam ta1m1kam deleted the feature/add-server-helpers-test branch May 7, 2022 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:server @simplewebauthn/server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants