Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/upgrade-asn1-libs #62

Merged
merged 3 commits into from
Oct 12, 2020
Merged

feature/upgrade-asn1-libs #62

merged 3 commits into from
Oct 12, 2020

Conversation

MasterKale
Copy link
Owner

This PR updates the @peculiar/asn1-* libraries to their latest version v2.0.23. This should help fix part of #61 by making server compatible with these latest releases that are getting pulled in anyway as sub-dependencies.

@MasterKale
Copy link
Owner Author

@P4sca1 tested this successfully, so I'm going to go ahead and merge this.

@MasterKale MasterKale marked this pull request as ready for review October 12, 2020 21:18
@MasterKale
Copy link
Owner Author

Also I acknowledge that this just kicks the can down the road a bit. It doesn't permanently solve for what to do when third-party packages release breaking changes as revision releases (v2.0.8 -> v2.0.23) when it should have been at least a minor release (v2.0.8 -> v2.1.0) ☹️

@MasterKale
Copy link
Owner Author

For reference later PR #68 successfully restored caret use in package versions so the latest asn1- packages should get picked up now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:server @simplewebauthn/server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant