Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up angular build config #614

Closed
therealryan opened this issue Nov 1, 2023 · 0 comments · Fixed by #616
Closed

Clean up angular build config #614

therealryan opened this issue Nov 1, 2023 · 0 comments · Fixed by #616
Labels
enhancement New feature or request good first issue Good for newcomers javascript Pull requests that update Javascript code

Comments

@therealryan
Copy link
Collaborator

The report app used to be two applications - one for the index page and one for the detail page. This worked OK, but it meant that reports carried two copies of a bunch of javascript - all the low-level angular stuff.
We did the work to unify the applications and eliminate the duplication, but I've just spotted a remnant that could be cleaned up:

  • The build-all scripts entry (this used to build both apps) - this can be deleted
  • The two places in the pom file where build-all is invoked - these can invoke build instead

This search shows them.

@therealryan therealryan added enhancement New feature or request good first issue Good for newcomers javascript Pull requests that update Javascript code labels Nov 1, 2023
@therealryan therealryan linked a pull request Nov 3, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant