further simplified and cleaned up tests

Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
Masterminds · Jan 28, 2021 · c707277 · c707277
1 parent 869801f
commit c707277
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 13 deletions.
diff --git a/cryptorandomstringutils.go b/cryptorandomstringutils.go
@@ -98,10 +98,6 @@ Returns:
 	error - an error stemming from an invalid parameter within underlying function, CryptoRandom(...)
 */
 func CryptoRandomAlphaNumeric(count int) (string, error) {
-	if count == 0 {
-		return "", nil
-	}
-
 	return CryptoRandom(count, 0, 0, true, true)
 }
 

diff --git a/cryptorandomstringutils_test.go b/cryptorandomstringutils_test.go
@@ -88,7 +88,6 @@ func TestCryptoRandAlphaNumeric_FuzzOnlyNumeric(t *testing.T) {
 		charlen++
 		for i := 0; i < iters; i++ {
 			out, err := CryptoRandomAlphaNumeric(charlen)
-			println(out)
 			if err != nil {
 				t.Fatal("func failed to produce a random thinger")
 			}

diff --git a/randomstringutils.go b/randomstringutils.go
@@ -99,13 +99,7 @@ Returns:
 	error - an error stemming from an invalid parameter within underlying function, RandomSeed(...)
 */
 func RandomAlphaNumeric(count int) (string, error) {
-	RandomString, err := Random(count, 0, 0, true, true)
-	if err != nil {
-		return "", fmt.Errorf("Error: %s", err)
-	}
-
-	return RandomString[:count], nil
-
+	return Random(count, 0, 0, true, true)
 }
 
 /*

diff --git a/randomstringutils_test.go b/randomstringutils_test.go
@@ -90,7 +90,6 @@ func TestRandAlphaNumeric_FuzzOnlyNumeric(t *testing.T) {
 		charlen++
 		for i := 0; i < iters; i++ {
 			out, err := RandomAlphaNumeric(charlen)
-			println(out)
 			if err != nil {
 				t.Fatal("func failed to produce a random thinger")
 			}