Custom namespaces #45
Conversation
|
@cognifloyd ping |
|
Even if it is not standard, this solution can help us to deal with some edge cases. $html = new HTML5(array(
"implicitNamespaces"=>["t"=>"http://www.example.com"]
));
$dom = $html->loadHTML('<t:div/>');
$dom->documentElement->namespaceURI; // http://www.example.com
$xp = new DOMXPath($dom);
$xp->registerNamespace("x", "http://www.example.com");
$xp->query("//x:div")->length; // 1Should work also: <body xmlns:x="http://www.prefixed.com">
<a id="bar1" xmlns="bar1">
<b id="bar4" xmlns="bar4"><x:prefixed id="prefixed"/></b>
</a>
<svg id="svg"></svg>
<c id="bar2" xmlns="bar2"></c>
<d id="bar3"></d>
</body>$bar1 = $dom->getElementById('bar1');
$this->assertEquals('bar1', $bar1->namespaceURI);
$bar2 = $dom->getElementById('bar2');
$this->assertEquals("bar2", $bar2->namespaceURI);
$bar3 = $dom->getElementById('bar3');
$this->assertEquals("http://www.w3.org/1999/xhtml", $bar3->namespaceURI);
$bar4 = $dom->getElementById('bar4');
$this->assertEquals("bar4", $bar4->namespaceURI);
$svg = $dom->getElementById('svg');
$this->assertEquals("http://www.w3.org/2000/svg", $svg->namespaceURI);
$svg = $dom->getElementById('prefixed');
$this->assertEquals("http://www.prefixed.com", $svg->namespaceURI); |
|
What about this problem? https://github.com/goetas/html5-php/pull/1 |
| $svg = $dom->getElementById('svg'); | ||
| $this->assertEquals("http://www.w3.org/2000/svg", $svg->namespaceURI); | ||
|
|
||
| $svg = $dom->getElementById('prefixed'); |
There was a problem hiding this comment.
I think you meant $prefixed...
|
Thanks @goetas this is much cleaner than my quick hack. The implicitNamespaces and xmlNamespaces options will need to be mentioned in the readme. +1 from me. Now, I'll look at goetas#1 |
|
@mattfarina @technosophos What is your about this implementation? |
|
I've been following this conversation, and I think this is the right direction for adding namespace support. We should probably have tests for HTML5 serialization to make sure that the result is valid or at least well formed enough that the serializer doesn't need any special case logic. Overall, though, I am excited that you all have made HTML5 into something far more flexible than what we initially envisioned. |
|
@technosophos i have wrote this test case to test some serialization isses https://github.com/goetas/html5-php/pull/1 It is not a clean approach but it works... |
|
@technosophos the approval of #37 is fundamental... |
|
@technosophos 2.0 will not be compatible with QueryPath... (css expressions now require a xml namespace...)
|
|
I thought I had a workaround for that in QueryPath already. It's not all that uncommon to get namespaced documents in QueryPath. But if that breaks QueryPath, so be it. I'll just have to go fix QueryPath. (It can handle namespaces with the CSS3 syntax: |
|
Almost ready |
| @@ -187,6 +186,9 @@ protected function attrs($ele) | |||
| // prefix. It seems that DOM does this for us already, but there | |||
| // may be exceptions. | |||
| $name = $node->name; | |||
| if ($name == "xmlns:x___xmlns__x") { | |||
There was a problem hiding this comment.
This needs to be documented somewhere, so that if someone uses the parser with their own serializer, they can still handle this case. Maybe this could go in the readme section about "known issues".
There was a problem hiding this comment.
A PR is welcome 😄 (implicitNamespaces and xmlNamespaces option too)
There was a problem hiding this comment.
I will add it to my list of stuff to document: cognifloyd#3
An extended implementation of #44 that supports also custom namespace prefixes and XML style namespaces.
See here to see an example: https://github.com/goetas/html5-php/blob/custom-namespaces/test/HTML5/Parser/DOMTreeBuilderTest.php#L99