Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"values" supports only one dictionary #158

Merged
merged 1 commit into from
Jun 14, 2019
Merged

"values" supports only one dictionary #158

merged 1 commit into from
Jun 14, 2019

Conversation

badeadan
Copy link
Contributor

@badeadan badeadan commented Jun 3, 2019

Documentation states values is similar to keys but keys supports listing keys from multiple dictionaries while values does not. It only supports one dictionary.

@badeadan
"values" supports only one dictionary
567f712 
Documentation states `values` is similar to `keys` but `keys` supports listing keys from multiple dictionaries while `values` does not. It only supports one dictionary.
mattfarina
mattfarina approved these changes Jun 14, 2019
View reviewed changes
Copy link
Member

@mattfarina mattfarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When these docs were written the keys function only supported on dict, IIRC. That's why the docs were the way they were. Thanks for the update.

@mattfarina mattfarina merged commit 90ce42e into Masterminds:master Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattfarina mattfarina mattfarina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@badeadan @mattfarina