Feature/move more parameters to config #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| @@ -208,6 +208,10 @@ | |||
| :runcmd | |||
| ["update-rc.d logstash defaults"]})) | |||
|
|
|||
| (defn open-elb-ports | |||
| [listeners] | |||
| (mapv #(assoc {} :port (or (:port %) (:lb_port %)) :cidr_blocks [all-external]) listeners)) | |||
There was a problem hiding this comment.
where does all-external come from?
There was a problem hiding this comment.
core.clj, it's hard-coded to 0.0.0.0/0
| :min-number-of-public-slaves 1 | ||
| :max-number-of-public-slaves 1 | ||
| :public-slave-instance-type "t2.medium" | ||
| :public-slave-elb-listeners [{:lb-port 443 :lb-protocol "https" :port 80 :protocol "http" :cert-name "c512707d-bbec-4859-ab22-0f5fbad62a22"} |
There was a problem hiding this comment.
this looks like the place for all of our specific config, so I'm guessing this UUID is fine?
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moves a number of things to parameters:
(also tightens the security on the public slaves to only allow traffic from ELB and within the VPN, and ELB to just have the relevant ports open)