Adding left and right joins. #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added specific left and right join fns, and made a default join that is right join (to match incanter). There is also an optional way to for callers to supply what they want empty cell values to be.
| (wds/join ds1 ds3 [:a]))) | ||
| (is | ||
| (= (d [:a :x :y :b] [[1 8 9 2]]) | ||
| (wds/join ds4 ds1 [:a]))))) |
There was a problem hiding this comment.
is it worth testing with multiple keys in the join?
There was a problem hiding this comment.
the larger test does do this, joins by [:b :c].
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added specific left and right join fns, and made a default join that is
right join (to match incanter). There is also an optional way to for
callers to supply what they want empty cell values to be.