Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix defmodel schema validation #37

Merged
merged 2 commits into from
Sep 20, 2016
Merged

Fix defmodel schema validation #37

merged 2 commits into from
Sep 20, 2016

Conversation

Eleonore9
Copy link
Contributor

  • On @acron0's instructions I moved defmodel schema validation within the quoted expression of the macro.
  • I added a test to check models can be defined when their workflow and catalog are def-ed separately.

acron0
acron0 suggested changes Sep 20, 2016
View reviewed changes
Copy link
Contributor

@acron0 acron0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great. Could you move the validate before the def inside the do? Also, please add a test which causes the model validation to fail and observes the exception.

@Eleonore9 Eleonore9 merged commit 4440950 into master Sep 20, 2016
@Eleonore9 Eleonore9 deleted the fix/defmodel-schema-validation branch September 20, 2016 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acron0 acron0 acron0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eleonore9 @acron0