Add Differential join's start_keys to EXPLAIN #16297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggevay
added
A-optimization
ggevay
force-pushed
the
start_keys_explain
branch
from
a77f29e
to
9c646b5
Compare
aalexandrov
approved these changes
Nov 28, 2022
ggevay
force-pushed
the
start_keys_explain
branch
from
9c646b5
to
08088a4
Compare
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up from #16099. Before that PR, the
start_keys/start_arrfield (theOption<Vec<MirScalarExpr>>) of theDifferentialJoinImplementationwas not used, and our EXPLAIN output was also not showing it. Now it is used in the MIR->LIR lowering, so this PR adds it also to the EXPLAIN output.The random reviewer is @tokenrove.
Motivation
EXPLAIN WITH(join_impls).Tips for reviewer
Checklist
This PR has adequate test coverage / QA involvement has been duly considered.
This PR evolves an existing
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way) and therefore is tagged with aT-protolabel.This PR includes the following user-facing behavior changes: