Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added GRAVITY attribute to SpaceScene #12

Merged
merged 2 commits into from
Dec 22, 2021
Merged

Added GRAVITY attribute to SpaceScene #12

merged 2 commits into from
Dec 22, 2021

Conversation

Myzel394
Copy link
Contributor

Added GRAVITY class method to SpaceScene.

IMPORTANT When changing GRAVITY, you need to rerender all partial videos. Simply disable the caching by providing the disable_caching flag.

Example

manim --disable_caching -pqh physics.py FallingEquation

icedcoffeeee
icedcoffeeee approved these changes Dec 8, 2021
View reviewed changes
Copy link
Collaborator

@icedcoffeeee icedcoffeeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This looks good to me, I wasn't sure if users wanted to specify the gravity constant themselves. But I guess this helps with that.

@icedcoffeeee icedcoffeeee changed the title Add gravity option Added GRAVITY attribute to SpaceScene Dec 8, 2021
@icedcoffeeee icedcoffeeee merged commit 0fe88c3 into Matheart:main Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icedcoffeeee icedcoffeeee icedcoffeeee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Myzel394 @icedcoffeeee