-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRAFT: Adds web command #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
Do make sure to add opener command for all supported OS.
Platform is already detected/known from here: https://github.com/rubygems/rubygems/blob/master/lib/rubygems/platform.rb#L79
fbe9b33
to
290f241
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good Matheus. It would be great if we could do QA test on the various supported platforms as well as unsupported ones. Maybe you can try it out for various OS with VirtualBox?
Now this command uses the BROWSER env variable to open links. If it is unset, the command just outputs the URL
adf7e71
to
c70106a
Compare
4918da7
to
3982cd6
Compare
3982cd6
to
d7656a1
Compare
89fb8ad
to
b0752dc
Compare
715232d
to
467205c
Compare
4f436b3
to
3e97da6
Compare
3e97da6
to
c9e19cd
Compare
Description:
Closes rubygems#2784.
Ruby claims to be "a programmer's best friend", and focus on "simplicity and productivity". As rubygems is now part of Ruby, I think it should follow those principles too.
I'm integrating gem-web into rubygems as part of GSoC 2019. This new command allows user to quickly find documentation of a gem.
I think this is specially good when one's not sure about what a gem does, or is confused with its name. Maybe the user wants to quickly check the rubygems' page of some gem (to check versions, dependencies, etc). With this command the access will be faster and easier with just one command on the terminal. Other use case could be opening the documentation for a gem, which improves productivity.
The usage would be like this:
Let me hear some feedback about this.
Platforms manually tested:
Tasks:
I will abide by the code of conduct.