Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nest): factory options methods made optional #15

Merged
merged 5 commits into from
Dec 25, 2022
Merged

Conversation

Matii96
Copy link
Owner

@Matii96 Matii96 commented Dec 25, 2022

the default values are now empty objects

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What is the current behavior?

Nest options factory requires methods returning empty object for each type of options.

What is the new behavior?

Empty options object is substituted in lib implementation.

the default values are now empty objects
@Matii96 Matii96 added the enhancement New feature or request label Dec 25, 2022
@Matii96 Matii96 self-assigned this Dec 25, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 25, 2022

Codecov Report

Merging #15 (2088d29) into main (f0a1d31) will decrease coverage by 0.29%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
- Coverage   95.29%   94.99%   -0.30%     
==========================================
  Files          68       68              
  Lines         637      639       +2     
  Branches       97       99       +2     
==========================================
  Hits          607      607              
- Misses         30       32       +2     
Flag Coverage Δ
unittests 94.99% <0.00%> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ckages/nest/lib/feature/mediator.feature.module.ts 67.64% <0.00%> (-2.05%) ⬇️
packages/nest/lib/root/mediator.root.module.ts 78.94% <0.00%> (-4.39%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Matii96 Matii96 merged commit 07aca7a into main Dec 25, 2022
@Matii96 Matii96 deleted the nest-improvements branch December 25, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants