Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): errors validation presenter json migration to core #20

Merged
merged 6 commits into from
Mar 17, 2024

Conversation

Matii96
Copy link
Owner

@Matii96 Matii96 commented Mar 17, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What is the current behavior?

Json errors validation presenter is provided by standalone package

What is the new behavior?

Json presenter moved to core package - no separate package installation required.

@unifig/validation-presenter-json package is deprecated but backwards compatible.

json presenter is provided out of the box from the core package

BREAKING CHANGE: json presenter deprecation
@Matii96 Matii96 added the enhancement New feature or request label Mar 17, 2024
@Matii96 Matii96 self-assigned this Mar 17, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.06%. Comparing base (5aefedb) to head (e8cc159).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   97.03%   97.06%   +0.02%     
==========================================
  Files          36       38       +2     
  Lines         405      409       +4     
  Branches       72       72              
==========================================
+ Hits          393      397       +4     
  Misses         12       12              
Flag Coverage Δ
unittests 97.06% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Matii96 Matii96 merged commit b05d7af into main Mar 17, 2024
9 checks passed
@Matii96 Matii96 deleted the validation-presenter-json-deprecation branch March 17, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants