Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(adapter-env): package rename from @unifig/adapter-env #6

Merged
merged 5 commits into from
Jan 2, 2023

Conversation

Matii96
Copy link
Owner

@Matii96 Matii96 commented Dec 22, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What is the current behavior?

Env adapter named @unifig/env which may lead to unclear setup when more adapters will be available.

What is the new behavior?

Env adapter named @unifig/adapter-env.

@Matii96 Matii96 added the enhancement New feature or request label Dec 22, 2022
@Matii96 Matii96 self-assigned this Dec 22, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2022

Codecov Report

Merging #6 (f7249ce) into main (7bbd86e) will decrease coverage by 0.53%.
The diff coverage is 97.92%.

@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
- Coverage   98.16%   97.62%   -0.54%     
==========================================
  Files          18       27       +9     
  Lines         218      295      +77     
  Branches       34       50      +16     
==========================================
+ Hits          214      288      +74     
- Misses          4        7       +3     
Flag Coverage Δ
unittests 97.62% <97.92%> (-0.54%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core/lib/validator/validator.impl.ts 93.93% <93.93%> (ø)
...ackages/validation-presenter-table/lib/to-table.ts 96.66% <96.66%> (ø)
packages/core/lib/manager/manager.impl.ts 96.77% <96.77%> (ø)
packages/adapter-env/lib/env.adapter.ts 100.00% <100.00%> (ø)
packages/core/lib/adapters/plain/plain.adapter.ts 100.00% <100.00%> (ø)
packages/core/lib/loader/constants.ts 100.00% <100.00%> (ø)
...ges/core/lib/loader/decorators/nested.decorator.ts 100.00% <100.00%> (ø)
packages/core/lib/loader/loader.impl.ts 100.00% <100.00%> (ø)
...kages/core/lib/manager/container/container.impl.ts 100.00% <100.00%> (ø)
...ger/exceptions/config-not-initialized.exception.ts 100.00% <100.00%> (ø)
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Matii96 Matii96 changed the title Adapter env rename feat(adapter-env): package rename from @unifig/adapter-env Dec 22, 2022
@Matii96 Matii96 merged commit b1ad90f into main Jan 2, 2023
@Matii96 Matii96 deleted the adapter-env-rename branch January 2, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants