Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): new flag defining whether types should be implicitly conv… #8

Merged
merged 5 commits into from
Jan 17, 2023

Conversation

Matii96
Copy link
Owner

@Matii96 Matii96 commented Jan 15, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What is the current behavior?

Forced implicit types conversion from adapter values to template properties. Example:

{ PORT: '3000' } -> { port: 3000 }

What is the new behavior?

The behavior can be disabled by setting enableImplicitConversion flag to false.

@Matii96 Matii96 added the enhancement New feature or request label Jan 15, 2023
@Matii96 Matii96 self-assigned this Jan 15, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2023

Codecov Report

Merging #8 (0b89d38) into main (baea3e6) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
+ Coverage   97.71%   97.73%   +0.01%     
==========================================
  Files          29       29              
  Lines         307      309       +2     
  Branches       55       56       +1     
==========================================
+ Hits          300      302       +2     
  Misses          7        7              
Flag Coverage Δ
unittests 97.73% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core/lib/loader/loader.impl.ts 100.00% <100.00%> (ø)
packages/core/lib/manager/manager.impl.ts 96.77% <100.00%> (ø)
...core/lib/manager/source-group/source-group.impl.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

packages/core/README.md Outdated Show resolved Hide resolved
@Matii96 Matii96 merged commit bf11f05 into main Jan 17, 2023
@Matii96 Matii96 deleted the register-options branch January 17, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants