Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec out the API for js-polykey #3

Closed
CMCDragonkai opened this issue Sep 12, 2018 · 3 comments · Fixed by #60
Closed

Spec out the API for js-polykey #3

CMCDragonkai opened this issue Sep 12, 2018 · 3 comments · Fixed by #60
Assignees
Labels
development Standard development

Comments

@CMCDragonkai
Copy link
Member

We need to spec out the function types for js-polykey and the data structures that we are managing.

I've written notes on this in the Polykey repository, but they are all over the place and involve some older ideas. Hopefully @ll-aashwin-ll can clean them up and a better spec.

https://github.com/MatrixAI/PolyKey

See README.md, README2.md... etc.

We can discuss the spec here and eventually write them into the code. This js-polykey can be the first reference implementation.

@MeanMangosteen
Copy link
Contributor

Since Polykey will predominantly have IO bound operations, we should definitely have async methods in the API.

From #9

Since the Polykey api does not have to preserve any existing API method signatures, like efs does with fs, it can use modern promise primitives for async methods instead of callbacks.

This will provide a much cleaner and future proof API.

Is it still worth having sync methods in polykey?

@CMCDragonkai
Copy link
Member Author

No it should just focus on async methods.

@CMCDragonkai
Copy link
Member Author

This issue could be closed soon with a spec for the Polykey api. At least an initial spec that we can iterate on. It can be in the docs directory. But generated docs is different from written docs. We would need to separate the 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Standard development
Development

Successfully merging a pull request may close this issue.

3 participants